Skip to content

Conversation

@ltardivo
Copy link
Collaborator

@ltardivo ltardivo commented Oct 2, 2024

The goal of this PR is to make it easier to run and configure a Bitcoin Computer Node. It also fixes some bugs detected when syncing to pepecoin testnet.

Fix issue 271 when syncing pepecoin through testnet.

  • Given that pepe does not have the function getBlock with a verbosity levels that returns the transaction hexes, we change the implementation to get that information by reading each transaction in the block using getRawTransaction.

Fix issue 270.

  • We now use a single .env at monorepo/packages/node to make the configuration easier
  • The user can now edit the bitcoin.conf file
  • The chain-setup folder has subfolders /CHAIN/NETWORK for each supported chain and network. These contain example files .env.example and bitcoin.conf for each chain and network.
  • To run the node the user can copy the .env and bitcoin.conf to the root level of packages/node, as described in the node README file
  • Rename of environment variables: Each variable related to the bitcoin node is preceded by BITCOIN_, each variable related to the bcn service is preceded by BCN_
  • Now there is only one single docker-compose.yml file at the root level of packages/node, reading parameters from .env
  • Remove monorepo/scripts root level ways to run, up, down and reset the node (we now have to go to the packages/node folder)
  • The database and blockchain data is stored now at the folder packages/node/data

More work needed

  • There are still issues with pepecoin, related with the defaults values (min_non_dust and related parameters), we created this issue to consider them next

@ltardivo ltardivo requested a review from ClemensLey October 2, 2024 22:17
@ClemensLey
Copy link
Contributor

Great work!

@ClemensLey ClemensLey merged commit 431bfed into main Oct 3, 2024
@ClemensLey ClemensLey deleted the feat/simplify-node-config branch October 3, 2024 22:48
@ltardivo ltardivo mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pepecoin testnet transactions are not parsed correctly CHAIN and NETWORK in .env have no effect

3 participants