Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segwit upgrade guide #240

Merged
merged 2 commits into from Oct 27, 2016
Merged

Add segwit upgrade guide #240

merged 2 commits into from Oct 27, 2016

Conversation

@harding
Copy link
Contributor

harding commented Oct 26, 2016

This adds a guide to upgrading (or not upgrading) to segwit for miners, node operators, wallet users, and Bitcoin devs.

  • A link to this guide is added to the FAQ menu.
  • A link is not added to the main page, as it seems like we'll be adding a link there soon enough for the 0.13.1 release.
  • All Markdown reference-style links to this document are defined, as verified by searching the rendered document for the string ][ that is indicative of an undefined link.
  • It is expected that the release blog for 0.13.1 will link to this document; however, I think it is safe to merge this document prior to the release if everyone is ok with it's content (which is why it's in a separate PR from the upcoming PR for the release blog).

A preview screenshot may be found here: http://imgur.com/a/DZGAg

Several people provided suggestions on this in draft form, for which I am very grateful. Any errors that appear in this version are entirely my fault.

Contains some text copy/pasted from `bitcoind -help` (MIT license).
@@ -0,0 +1,212 @@
---
version: 1

This comment has been minimized.

@btcdrak

btcdrak Oct 26, 2016 Contributor

double version (again at the bottom)

@kanzure
Copy link

kanzure commented Oct 26, 2016

ACK 290d0c4. Also possibly consider adding a link to /en/2016/01/26/segwit-benefits/. Looking good.

@harding harding mentioned this pull request Oct 27, 2016
1 of 4 tasks complete
@btcdrak btcdrak merged commit dd93b36 into gh-pages Oct 27, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
btcdrak added a commit that referenced this pull request Oct 27, 2016
dd93b36 Convert to blog post (BtcDrak)
290d0c4 Add segwit upgrade guide (David A. Harding)
@btcdrak btcdrak deleted the segwit-upgrade-guide branch Oct 27, 2016
@btcdrak
Copy link
Contributor

btcdrak commented Oct 27, 2016

Converted to a blog post, makes it more accessible. Agree with @kanzure to add link to segwit benefits.

@btcdrak btcdrak added the blog label Oct 27, 2016
@btcdrak
Copy link
Contributor

btcdrak commented Oct 27, 2016

@harding Thank you very much

@laanwj
Copy link
Member

laanwj commented Oct 27, 2016

post-merge ACK, thanks!

@kanzure
Copy link

kanzure commented Oct 27, 2016

Navigation menu link is pointing to /en/segwit-upgrade-guide but permalink is /en/2016/10/27/segwit-upgrade-guide/.

@btcdrak
Copy link
Contributor

btcdrak commented Oct 27, 2016

@kanzure I dont understand why, the links are updated in the navigation.yml

@harding
Copy link
Contributor Author

harding commented Oct 27, 2016

@btcdrak There's a build error:

$ bundle exec jekyll serve --future
Configuration file: /home/user/bitcoincore.org/_config.yml
            Source: /home/user/bitcoincore.org
       Destination: /home/user/bitcoincore.org/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
jekyll 3.0.2 | Error:  (/home/user/bitcoincore.org/_data/navigation.yml): did not find expected key while parsing a block mapping at line 128 column 6
@btcdrak
Copy link
Contributor

btcdrak commented Oct 27, 2016

@harding thanks, indentation was wrong. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.