From 28fff06afe98177c14a932abf95b380bb51c6653 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Wed, 14 Jun 2023 16:26:11 +0100 Subject: [PATCH] test: Make linter to look for `BOOST_ASSERT` macros The `BOOST_ASSERT` macro requires to `#include boost/assert.hpp`. --- test/lint/lint-assertions.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/lint/lint-assertions.py b/test/lint/lint-assertions.py index e7eecebce59..6da59b0d48d 100755 --- a/test/lint/lint-assertions.py +++ b/test/lint/lint-assertions.py @@ -45,6 +45,16 @@ def main(): ":(exclude)src/rpc/server.cpp", ], "CHECK_NONFATAL(condition) or NONFATAL_UNREACHABLE should be used instead of assert for RPC code.") + # The `BOOST_ASSERT` macro requires to `#include boost/assert.hpp`, + # which is an unnecessary Boost dependency. + exit_code |= git_grep([ + "-E", + r"BOOST_ASSERT *\(.*\);", + "--", + "*.cpp", + "*.h", + ], "BOOST_ASSERT must be replaced with Assert, BOOST_REQUIRE, or BOOST_CHECK.") + sys.exit(exit_code)