cmake: avoid libatomic not found error on debian #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add workaround to prevent "libatomic not found" when building on debian against debian capnproto package which installs a buggy CapnProtoConfig.cmake file. The bug was introduced as part of debian's attempt to fix a different issue: capnproto/capnproto#1448 and their fix works for autoconf projects but not cmake projects like libmultiprocess. Fixes bitcoin-core#68
33 tasks
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 16, 2024
Add recent changes and fixes for shutdown bugs. bitcoin-core/libmultiprocess#111: doc: Add internal design section bitcoin-core/libmultiprocess#113: Add missing include to util.h bitcoin-core/libmultiprocess#116: shutdown bugfix: destroy RPC system before running cleanup callbacks bitcoin-core/libmultiprocess#118: shutdown bugfix: Prevent segfault in server if connection is broken during long function call bitcoin-core/libmultiprocess#119: cmake: avoid libatomic not found error on debian
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Oct 21, 2024
90b4055 Update libmultiprocess library (Ryan Ofsky) Pull request description: Add recent changes and fixes for shutdown bugs. bitcoin-core/libmultiprocess#111: doc: Add internal design section bitcoin-core/libmultiprocess#113: Add missing include to util.h bitcoin-core/libmultiprocess#116: shutdown bugfix: destroy RPC system before running cleanup callbacks bitcoin-core/libmultiprocess#118: shutdown bugfix: Prevent segfault in server if connection is broken during long function call bitcoin-core/libmultiprocess#119: cmake: avoid libatomic not found error on debian ACKs for top commit: fanquake: ACK 90b4055 TheCharlatan: ACK 90b4055 Tree-SHA512: 2c256667f0c16e00bb5a81b2c6d3db103fae211844e32b111bbed673ab2612ad1478e6b3ecd3a867a4e425cfa6e778b67388343626597a8fac800a15cea5e53a
hebasto
reviewed
Oct 24, 2024
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Jan 19, 2025
Add recent changes and fixes for shutdown bugs. bitcoin-core/libmultiprocess#111: doc: Add internal design section bitcoin-core/libmultiprocess#113: Add missing include to util.h bitcoin-core/libmultiprocess#116: shutdown bugfix: destroy RPC system before running cleanup callbacks bitcoin-core/libmultiprocess#118: shutdown bugfix: Prevent segfault in server if connection is broken during long function call bitcoin-core/libmultiprocess#119: cmake: avoid libatomic not found error on debian
ryanofsky
added a commit
to ryanofsky/libmultiprocess
that referenced
this pull request
Jan 23, 2025
This is an extension of the workaround implemented previously in bitcoin-core#119. That workaround let the libmultiprocess cmake build work with the debian capnproto package. This change extends the workaround to apply to downstream cmake builds that call find_package(Libmultiprocess), like Bitcoin Core. Fixes bitcoin-core#132
ryanofsky
added a commit
that referenced
this pull request
Jan 27, 2025
67afc23 Fix debian "libatomic not found" error in downstream builds (Ryan Ofsky) Pull request description: This is an extension of the workaround implemented previously in #119. That workaround let the libmultiprocess cmake build work with the debian capnproto package. This change extends the workaround to apply to downstream cmake builds that call find_package(Libmultiprocess), like Bitcoin Core. Fixes #132 ACKs for top commit: hebasto: ACK 67afc23, tested on Ubuntu 24.04. Tree-SHA512: 9b02f9f4d9aea3ac241641fe857dd91e110252c93351ed2fdd0bcd48f3dbfea3b3d5476774a2d4b89a70c955a7c7fc69eaba6f0a41e853e2eb03d3dae6ad3c8e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workaround to prevent "libatomic not found" when building on debian against debian capnproto package which installs a buggy CapnProtoConfig.cmake file. The bug was introduced as part of debian's attempt to fix a different issue: capnproto/capnproto#1448 and their fix works for autoconf projects but not cmake projects like libmultiprocess.
Fixes #68