From 359a6157af0e69e844a3a61b8e14d452f686f083 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:31:55 +0000
Subject: [PATCH 01/14] clang-tidy: Disable `misc-use-anonymous-namespace`
 check

The benefit of this check is questionable, so it has been disabled.
See: https://clang.llvm.org/extra/clang-tidy/checks/misc/use-anonymous-namespace.html
---
 .clang-tidy | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.clang-tidy b/.clang-tidy
index 3ab59c7b..5699a6f2 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -11,6 +11,7 @@ misc-*,
 -misc-no-recursion,
 -misc-unconventional-assign-operator,
 -misc-unused-parameters,
+-misc-use-anonymous-namespace,
 modernize-*,
 -modernize-avoid-c-arrays,
 -modernize-concat-nested-namespaces,

From 00036c064856449675b54117a3437bad1cf648ca Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:32:04 +0000
Subject: [PATCH 02/14] clang-tidy: Disable `performance-avoid-endl` check

See: https://clang.llvm.org/extra/clang-tidy/checks/performance/avoid-endl.html
---
 .clang-tidy | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.clang-tidy b/.clang-tidy
index 5699a6f2..2d29f120 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -20,6 +20,7 @@ modernize-*,
 -modernize-use-trailing-return-type,
 -modernize-use-using,
 performance-*,
+-performance-avoid-endl,
 -performance-noexcept-move-constructor,
 readability-*,
 -readability-braces-around-statements,

From c068596ac3dae64212729267c608c4431baf1774 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:32:18 +0000
Subject: [PATCH 03/14] clang-tidy: Fix
 `bugprone-crtp-constructor-accessibility` check

See: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/empty-catch.html
---
 include/mp/proxy-types.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/mp/proxy-types.h b/include/mp/proxy-types.h
index 6c1b1aae..40cce321 100644
--- a/include/mp/proxy-types.h
+++ b/include/mp/proxy-types.h
@@ -314,6 +314,9 @@ struct IterateFieldsHelper
     {
         static_cast<Derived*>(this)->handleField(std::forward<Arg1>(arg1), std::forward<Arg2>(arg2), ParamList());
     }
+private:
+    IterateFieldsHelper() = default;
+    friend Derived;
 };
 
 struct IterateFields : IterateFieldsHelper<IterateFields, 0>

From 8170d3d421da1bd3ab735b18354fce8dd4cfd7ed Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:32:31 +0000
Subject: [PATCH 04/14] clang-tidy: Suppress `bugprone-empty-catch` check
 warning

See: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/empty-catch.html
---
 include/mp/util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/mp/util.h b/include/mp/util.h
index 032fc0f1..3966e281 100644
--- a/include/mp/util.h
+++ b/include/mp/util.h
@@ -157,7 +157,7 @@ struct DestructorCatcher
     {
     }
     ~DestructorCatcher() noexcept try {
-    } catch (const kj::Exception& e) {
+    } catch (const kj::Exception& e) { // NOLINT(bugprone-empty-catch)
     }
 };
 

From 4a2508c49978bbbcadd7bbff1543bdf44310c74a Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:32:56 +0000
Subject: [PATCH 05/14] clang-tidy: Fix `modernize-type-traits` check

See: https://clang.llvm.org/extra/clang-tidy/checks/modernize/type-traits.html
---
 include/mp/proxy-types.h | 30 +++++++++++++++---------------
 include/mp/proxy.h       |  2 +-
 include/mp/util.h        |  8 ++++----
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/include/mp/proxy-types.h b/include/mp/proxy-types.h
index 40cce321..384ecaae 100644
--- a/include/mp/proxy-types.h
+++ b/include/mp/proxy-types.h
@@ -39,17 +39,17 @@ struct StructField
 
     // clang-format off
     template<typename A = Accessor> auto get() const -> decltype(A::get(this->m_struct)) { return A::get(this->m_struct); }
-    template<typename A = Accessor> auto has() const -> typename std::enable_if<A::optional, bool>::type { return A::getHas(m_struct); }
-    template<typename A = Accessor> auto has() const -> typename std::enable_if<!A::optional && A::boxed, bool>::type { return A::has(m_struct); }
-    template<typename A = Accessor> auto has() const -> typename std::enable_if<!A::optional && !A::boxed, bool>::type { return true; }
-    template<typename A = Accessor> auto want() const -> typename std::enable_if<A::requested, bool>::type { return A::getWant(m_struct); }
-    template<typename A = Accessor> auto want() const -> typename std::enable_if<!A::requested, bool>::type { return true; }
+    template<typename A = Accessor> auto has() const -> std::enable_if_t<A::optional, bool> { return A::getHas(m_struct); }
+    template<typename A = Accessor> auto has() const -> std::enable_if_t<!A::optional && A::boxed, bool> { return A::has(m_struct); }
+    template<typename A = Accessor> auto has() const -> std::enable_if_t<!A::optional && !A::boxed, bool> { return true; }
+    template<typename A = Accessor> auto want() const -> std::enable_if_t<A::requested, bool> { return A::getWant(m_struct); }
+    template<typename A = Accessor> auto want() const -> std::enable_if_t<!A::requested, bool> { return true; }
     template<typename A = Accessor, typename... Args> decltype(auto) set(Args&&... args) const { return A::set(this->m_struct, std::forward<Args>(args)...); }
     template<typename A = Accessor, typename... Args> decltype(auto) init(Args&&... args) const { return A::init(this->m_struct, std::forward<Args>(args)...); }
-    template<typename A = Accessor> auto setHas() const -> typename std::enable_if<A::optional>::type { return A::setHas(m_struct); }
-    template<typename A = Accessor> auto setHas() const -> typename std::enable_if<!A::optional>::type { }
-    template<typename A = Accessor> auto setWant() const -> typename std::enable_if<A::requested>::type { return A::setWant(m_struct); }
-    template<typename A = Accessor> auto setWant() const -> typename std::enable_if<!A::requested>::type { }
+    template<typename A = Accessor> auto setHas() const -> std::enable_if_t<A::optional> { return A::setHas(m_struct); }
+    template<typename A = Accessor> auto setHas() const -> std::enable_if_t<!A::optional> { }
+    template<typename A = Accessor> auto setWant() const -> std::enable_if_t<A::requested> { return A::setWant(m_struct); }
+    template<typename A = Accessor> auto setWant() const -> std::enable_if_t<!A::requested> { }
     // clang-format on
 };
 
@@ -375,14 +375,14 @@ struct ClientParam
         // position when unpacking tuple might be slower than pattern matching
         // approach in the stack overflow solution
         template <size_t I, typename... Args>
-        auto callBuild(Args&&... args) -> typename std::enable_if<(I < sizeof...(Types))>::type
+        auto callBuild(Args&&... args) -> std::enable_if_t<(I < sizeof...(Types))>
         {
             callBuild<I + 1>(std::forward<Args>(args)..., std::get<I>(m_client_param->m_values));
         }
 
         template <size_t I, typename Params, typename ParamList, typename... Values>
         auto callBuild(ClientInvokeContext& invoke_context, Params& params, ParamList, Values&&... values) ->
-            typename std::enable_if<(I == sizeof...(Types))>::type
+            std::enable_if_t<(I == sizeof...(Types))>
         {
             MaybeBuildField(std::integral_constant<bool, Accessor::in>(), ParamList(), invoke_context,
                 Make<StructField, Accessor>(params), std::forward<Values>(values)...);
@@ -403,14 +403,14 @@ struct ClientParam
         }
 
         template <int I, typename... Args>
-        auto callRead(Args&&... args) -> typename std::enable_if<(I < sizeof...(Types))>::type
+        auto callRead(Args&&... args) -> std::enable_if_t<(I < sizeof...(Types))>
         {
             callRead<I + 1>(std::forward<Args>(args)..., std::get<I>(m_client_param->m_values));
         }
 
         template <int I, typename Results, typename... Params, typename... Values>
         auto callRead(ClientInvokeContext& invoke_context, Results& results, TypeList<Params...>, Values&&... values)
-            -> typename std::enable_if<I == sizeof...(Types)>::type
+            -> std::enable_if_t<I == sizeof...(Types)>
         {
             MaybeReadField(std::integral_constant<bool, Accessor::out>(), TypeList<Decay<Params>...>(), invoke_context,
                 Make<StructField, Accessor>(results), ReadDestUpdate(values)...);
@@ -651,7 +651,7 @@ void clientInvoke(ProxyClient& proxy_client, const GetRequest& get_request, Fiel
 //! duplication and branching in generic code that forwards calls to functions.
 template <typename Fn, typename Ret>
 auto ReplaceVoid(Fn&& fn, Ret&& ret) ->
-    typename std::enable_if<std::is_same<void, decltype(fn())>::value, decltype(ret())>::type
+    std::enable_if_t<std::is_same_v<void, decltype(fn())>, decltype(ret())>
 {
     fn();
     return ret();
@@ -660,7 +660,7 @@ auto ReplaceVoid(Fn&& fn, Ret&& ret) ->
 //! Overload of above for non-void `fn()` case.
 template <typename Fn, typename Ret>
 auto ReplaceVoid(Fn&& fn, Ret&& ret) ->
-    typename std::enable_if<!std::is_same<void, decltype(fn())>::value, decltype(fn())>::type
+    std::enable_if_t<!std::is_same_v<void, decltype(fn())>, decltype(fn())>
 {
     return fn();
 }
diff --git a/include/mp/proxy.h b/include/mp/proxy.h
index 92c0fa56..76be0992 100644
--- a/include/mp/proxy.h
+++ b/include/mp/proxy.h
@@ -198,7 +198,7 @@ struct FunctionTraits<_Result (_Class::*const)(_Params...)>
     template <size_t N>
     using Param = typename std::tuple_element<N, std::tuple<_Params...>>::type;
     using Fields =
-        typename std::conditional<std::is_same<void, Result>::value, Params, TypeList<_Params..., _Result>>::type;
+        std::conditional_t<std::is_same_v<void, Result>, Params, TypeList<_Params..., _Result>>;
 };
 
 //! Traits class for a proxy method, providing the same
diff --git a/include/mp/util.h b/include/mp/util.h
index 3966e281..6ed631e1 100644
--- a/include/mp/util.h
+++ b/include/mp/util.h
@@ -43,9 +43,9 @@ struct TypeList
 //! Example:
 //!   Make<std::pair>(5, true) // Constructs std::pair<int, bool>(5, true);
 template <template <typename...> class Class, typename... Types, typename... Args>
-Class<Types..., typename std::remove_reference<Args>::type...> Make(Args&&... args)
+Class<Types..., std::remove_reference_t<Args>...> Make(Args&&... args)
 {
-    return Class<Types..., typename std::remove_reference<Args>::type...>{std::forward<Args>(args)...};
+    return Class<Types..., std::remove_reference_t<Args>...>{std::forward<Args>(args)...};
 }
 
 //! Type helper splitting a TypeList into two halves at position index.
@@ -83,7 +83,7 @@ using RemoveCvRef = std::remove_cv_t<std::remove_reference_t<T>>;
 
 //! Type helper abbreviating std::decay.
 template <typename T>
-using Decay = typename std::decay<T>::type;
+using Decay = std::decay_t<T>;
 
 //! SFINAE helper, see using Require below.
 template <typename SfinaeExpr, typename Result_>
@@ -181,7 +181,7 @@ struct AsyncCallable
 
 //! Construct AsyncCallable object.
 template <typename Callable>
-AsyncCallable<typename std::remove_reference<Callable>::type> MakeAsyncCallable(Callable&& callable)
+AsyncCallable<std::remove_reference_t<Callable>> MakeAsyncCallable(Callable&& callable)
 {
     return std::move(callable);
 }

From 848c902dd0cd39c0bb89a67ee03cb56bb47c002e Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:33:07 +0000
Subject: [PATCH 06/14] clang-tidy: Fix `misc-const-correctness` check

See: https://clang.llvm.org/extra/clang-tidy/checks/misc/const-correctness.html

Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
---
 example/calculator.cpp   |  2 +-
 example/example.cpp      |  2 +-
 example/printer.cpp      |  2 +-
 include/mp/proxy-io.h    |  4 ++--
 include/mp/proxy-types.h |  4 ++--
 include/mp/util.h        |  2 +-
 src/mp/gen.cpp           | 28 ++++++++++++++--------------
 src/mp/proxy.cpp         | 24 ++++++++++++------------
 src/mp/util.cpp          |  4 ++--
 9 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/example/calculator.cpp b/example/calculator.cpp
index 65f6476e..26cc8088 100644
--- a/example/calculator.cpp
+++ b/example/calculator.cpp
@@ -43,7 +43,7 @@ int main(int argc, char** argv)
         return 1;
     }
     mp::EventLoop loop("mpcalculator", LogPrint);
-    int fd = std::stoi(argv[1]);
+    const int fd = std::stoi(argv[1]);
     std::unique_ptr<Init> init = std::make_unique<InitImpl>();
     mp::ServeStream<InitInterface>(loop, fd, *init);
     loop.loop();
diff --git a/example/example.cpp b/example/example.cpp
index 036dcb53..dcd6a68f 100644
--- a/example/example.cpp
+++ b/example/example.cpp
@@ -14,7 +14,7 @@ namespace fs = std::filesystem;
 auto Spawn(mp::EventLoop& loop, const std::string& process_argv0, const std::string& new_exe_name)
 {
     int pid;
-    int fd = mp::SpawnProcess(pid, [&](int fd) -> std::vector<std::string> {
+    const int fd = mp::SpawnProcess(pid, [&](int fd) -> std::vector<std::string> {
         fs::path path = process_argv0;
         path.remove_filename();
         path.append(new_exe_name);
diff --git a/example/printer.cpp b/example/printer.cpp
index 0a51cdd4..6f2a4949 100644
--- a/example/printer.cpp
+++ b/example/printer.cpp
@@ -37,7 +37,7 @@ int main(int argc, char** argv)
         return 1;
     }
     mp::EventLoop loop("mpprinter", LogPrint);
-    int fd = std::stoi(argv[1]);
+    const int fd = std::stoi(argv[1]);
     std::unique_ptr<Init> init = std::make_unique<InitImpl>();
     mp::ServeStream<InitInterface>(loop, fd, *init);
     loop.loop();
diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h
index cc459d38..aeb987c8 100644
--- a/include/mp/proxy-io.h
+++ b/include/mp/proxy-io.h
@@ -247,7 +247,7 @@ struct Waiter
     template <typename Fn>
     void post(Fn&& fn)
     {
-        std::unique_lock<std::mutex> lock(m_mutex);
+        const std::unique_lock<std::mutex> lock(m_mutex);
         assert(!m_fn);
         m_fn = std::move(fn);
         m_cv.notify_all();
@@ -269,7 +269,7 @@ struct Waiter
                 fn();
                 lock.lock();
             }
-            bool done = pred();
+            const bool done = pred();
             return done;
         });
     }
diff --git a/include/mp/proxy-types.h b/include/mp/proxy-types.h
index 384ecaae..1a519efd 100644
--- a/include/mp/proxy-types.h
+++ b/include/mp/proxy-types.h
@@ -626,7 +626,7 @@ void clientInvoke(ProxyClient& proxy_client, const GetRequest& get_request, Fiel
                 } catch (...) {
                     exception = std::current_exception();
                 }
-                std::unique_lock<std::mutex> lock(invoke_context.thread_context.waiter->m_mutex);
+                const std::unique_lock<std::mutex> lock(invoke_context.thread_context.waiter->m_mutex);
                 done = true;
                 invoke_context.thread_context.waiter->m_cv.notify_all();
             },
@@ -634,7 +634,7 @@ void clientInvoke(ProxyClient& proxy_client, const GetRequest& get_request, Fiel
                 kj_exception = kj::str("kj::Exception: ", e).cStr();
                 proxy_client.m_context.connection->m_loop.logPlain()
                     << "{" << invoke_context.thread_context.thread_name << "} IPC client exception " << kj_exception;
-                std::unique_lock<std::mutex> lock(invoke_context.thread_context.waiter->m_mutex);
+                const std::unique_lock<std::mutex> lock(invoke_context.thread_context.waiter->m_mutex);
                 done = true;
                 invoke_context.thread_context.waiter->m_cv.notify_all();
             }));
diff --git a/include/mp/util.h b/include/mp/util.h
index 6ed631e1..ebfc3b5e 100644
--- a/include/mp/util.h
+++ b/include/mp/util.h
@@ -142,7 +142,7 @@ struct UnlockGuard
 template <typename Lock, typename Callback>
 void Unlock(Lock& lock, Callback&& callback)
 {
-    UnlockGuard<Lock> unlock(lock);
+    const UnlockGuard<Lock> unlock(lock);
     callback();
 }
 
diff --git a/src/mp/gen.cpp b/src/mp/gen.cpp
index 93b001f6..66298346 100644
--- a/src/mp/gen.cpp
+++ b/src/mp/gen.cpp
@@ -151,7 +151,7 @@ void Generate(kj::StringPtr src_prefix,
     }
 
     std::string include_base = include_path;
-    std::string::size_type p = include_base.rfind('.');
+    const std::string::size_type p = include_base.rfind('.');
     if (p != std::string::npos) include_base.erase(p);
 
     std::vector<std::string> args;
@@ -165,19 +165,19 @@ void Generate(kj::StringPtr src_prefix,
     }
     args.emplace_back("--output=" capnp_PREFIX "/bin/capnpc-c++");
     args.emplace_back(src_file);
-    int pid = fork();
+    const int pid = fork();
     if (pid == -1) {
         throw std::system_error(errno, std::system_category(), "fork");
     }
     if (!pid) {
         mp::ExecProcess(args);
     }
-    int status = mp::WaitProcess(pid);
+    const int status = mp::WaitProcess(pid);
     if (status) {
         throw std::runtime_error("Invoking " capnp_PREFIX "/bin/capnp failed");
     }
 
-    capnp::SchemaParser parser;
+    const capnp::SchemaParser parser;
     auto directory_pointers = kj::heapArray<const kj::ReadableDirectory*>(import_dirs.size());
     for (size_t i = 0; i < import_dirs.size(); ++i) {
         directory_pointers[i] = import_dirs[i].get();
@@ -244,7 +244,7 @@ void Generate(kj::StringPtr src_prefix,
     GetAnnotationText(file_schema.getProto(), NAMESPACE_ANNOTATION_ID, &message_namespace);
 
     std::string base_name = include_base;
-    size_t output_slash = base_name.rfind('/');
+    const size_t output_slash = base_name.rfind('/');
     if (output_slash != std::string::npos) {
         base_name.erase(0, output_slash + 1);
     }
@@ -260,7 +260,7 @@ void Generate(kj::StringPtr src_prefix,
 
     auto add_accessor = [&](kj::StringPtr name) {
         if (!accessors_done.insert(name).second) return;
-        std::string cap = Cap(name);
+        const std::string cap = Cap(name);
         accessors << "struct " << cap << "\n";
         accessors << "{\n";
         accessors << "    template<typename S> static auto get(S&& s) -> decltype(s.get" << cap << "()) { return s.get" << cap << "(); }\n";
@@ -368,19 +368,19 @@ void Generate(kj::StringPtr src_prefix,
             server << "    using ProxyServerCustom::ProxyServerCustom;\n";
             server << "    ~ProxyServer();\n";
 
-            std::ostringstream client_construct;
-            std::ostringstream client_destroy;
+            const std::ostringstream client_construct;
+            const std::ostringstream client_destroy;
 
             int method_ordinal = 0;
             ForEachMethod(interface, [&] (const capnp::InterfaceSchema& method_interface, const capnp::InterfaceSchema::Method& method) {
-                kj::StringPtr method_name = method.getProto().getName();
+                const kj::StringPtr method_name = method.getProto().getName();
                 kj::StringPtr proxied_method_name = method_name;
                 GetAnnotationText(method.getProto(), NAME_ANNOTATION_ID, &proxied_method_name);
 
                 const std::string method_prefix = Format() << message_namespace << "::" << method_interface.getShortDisplayName()
                                                            << "::" << Cap(method_name);
-                bool is_construct = method_name == "construct";
-                bool is_destroy = method_name == "destroy";
+                const bool is_construct = method_name == "construct";
+                const bool is_destroy = method_name == "destroy";
 
                 struct Field
                 {
@@ -530,9 +530,9 @@ void Generate(kj::StringPtr src_prefix,
                     server_invoke_end << ")";
                 }
 
-                std::string static_str{is_construct || is_destroy ? "static " : ""};
-                std::string super_str{is_construct || is_destroy ? "Super& super" : ""};
-                std::string self_str{is_construct || is_destroy ? "super" : "*this"};
+                const std::string static_str{is_construct || is_destroy ? "static " : ""};
+                const std::string super_str{is_construct || is_destroy ? "Super& super" : ""};
+                const std::string self_str{is_construct || is_destroy ? "super" : "*this"};
 
                 client << "    using M" << method_ordinal << " = ProxyClientMethodTraits<" << method_prefix
                        << "Params>;\n";
diff --git a/src/mp/proxy.cpp b/src/mp/proxy.cpp
index d9ad4f39..1bdc9b1a 100644
--- a/src/mp/proxy.cpp
+++ b/src/mp/proxy.cpp
@@ -102,7 +102,7 @@ Connection::~Connection()
         m_sync_cleanup_fns.pop_front();
     }
     while (!m_async_cleanup_fns.empty()) {
-        std::unique_lock<std::mutex> lock(m_loop.m_mutex);
+        const std::unique_lock<std::mutex> lock(m_loop.m_mutex);
         m_loop.m_async_fns.emplace_back(std::move(m_async_cleanup_fns.front()));
         m_async_cleanup_fns.pop_front();
     }
@@ -113,7 +113,7 @@ Connection::~Connection()
 
 CleanupIt Connection::addSyncCleanup(std::function<void()> fn)
 {
-    std::unique_lock<std::mutex> lock(m_loop.m_mutex);
+    const std::unique_lock<std::mutex> lock(m_loop.m_mutex);
     // Add cleanup callbacks to the front of list, so sync cleanup functions run
     // in LIFO order. This is a good approach because sync cleanup functions are
     // added as client objects are created, and it is natural to clean up
@@ -127,13 +127,13 @@ CleanupIt Connection::addSyncCleanup(std::function<void()> fn)
 
 void Connection::removeSyncCleanup(CleanupIt it)
 {
-    std::unique_lock<std::mutex> lock(m_loop.m_mutex);
+    const std::unique_lock<std::mutex> lock(m_loop.m_mutex);
     m_sync_cleanup_fns.erase(it);
 }
 
 void Connection::addAsyncCleanup(std::function<void()> fn)
 {
-    std::unique_lock<std::mutex> lock(m_loop.m_mutex);
+    const std::unique_lock<std::mutex> lock(m_loop.m_mutex);
     // Add async cleanup callbacks to the back of the list. Unlike the sync
     // cleanup list, this list order is more significant because it determines
     // the order server objects are destroyed when there is a sudden disconnect,
@@ -169,7 +169,7 @@ EventLoop::EventLoop(const char* exe_name, LogFn log_fn, void* context)
 EventLoop::~EventLoop()
 {
     if (m_async_thread.joinable()) m_async_thread.join();
-    std::lock_guard<std::mutex> lock(m_mutex);
+    const std::lock_guard<std::mutex> lock(m_mutex);
     KJ_ASSERT(m_post_fn == nullptr);
     KJ_ASSERT(m_async_fns.empty());
     KJ_ASSERT(m_wait_fd == -1);
@@ -192,7 +192,7 @@ void EventLoop::loop()
     int post_fd{m_post_fd};
     char buffer = 0;
     for (;;) {
-        size_t read_bytes = wait_stream->read(&buffer, 0, 1).wait(m_io_context.waitScope);
+        const size_t read_bytes = wait_stream->read(&buffer, 0, 1).wait(m_io_context.waitScope);
         if (read_bytes != 1) throw std::logic_error("EventLoop wait_stream closed unexpectedly");
         std::unique_lock<std::mutex> lock(m_mutex);
         if (m_post_fn) {
@@ -212,7 +212,7 @@ void EventLoop::loop()
     log() << "EventLoop::loop bye.";
     wait_stream = nullptr;
     KJ_SYSCALL(::close(post_fd));
-    std::unique_lock<std::mutex> lock(m_mutex);
+    const std::unique_lock<std::mutex> lock(m_mutex);
     m_wait_fd = -1;
     m_post_fd = -1;
 }
@@ -258,7 +258,7 @@ void EventLoop::startAsyncThread(std::unique_lock<std::mutex>& lock)
             while (true) {
                 if (!m_async_fns.empty()) {
                     addClient(lock);
-                    std::function<void()> fn = std::move(m_async_fns.front());
+                    const std::function<void()> fn = std::move(m_async_fns.front());
                     m_async_fns.pop_front();
                     Unlock(lock, fn);
                     removeClient(lock);
@@ -282,7 +282,7 @@ bool EventLoop::done(std::unique_lock<std::mutex>& lock)
 
 std::tuple<ConnThread, bool> SetThread(ConnThreads& threads, std::mutex& mutex, Connection* connection, std::function<Thread::Client()> make_thread)
 {
-    std::unique_lock<std::mutex> lock(mutex);
+    const std::unique_lock<std::mutex> lock(mutex);
     auto thread = threads.find(connection);
     if (thread != threads.end()) return {thread, false};
     thread = threads.emplace(
@@ -299,7 +299,7 @@ std::tuple<ConnThread, bool> SetThread(ConnThreads& threads, std::mutex& mutex,
         // try unregister this callback after connection is destroyed.
         thread->second.m_cleanup_it.reset();
         // Remove connection pointer about to be destroyed from the map
-        std::unique_lock<std::mutex> lock(mutex);
+        const std::unique_lock<std::mutex> lock(mutex);
         threads.erase(thread);
     });
     return {thread, true};
@@ -339,7 +339,7 @@ ProxyServer<Thread>::~ProxyServer()
     assert(m_thread_context.waiter.get());
     std::unique_ptr<Waiter> waiter;
     {
-        std::unique_lock<std::mutex> lock(m_thread_context.waiter->m_mutex);
+        const std::unique_lock<std::mutex> lock(m_thread_context.waiter->m_mutex);
         //! Reset thread context waiter pointer, as shutdown signal for done
         //! lambda passed as waiter->wait() argument in makeThread code below.
         waiter = std::move(m_thread_context.waiter);
@@ -367,7 +367,7 @@ ProxyServer<ThreadMap>::ProxyServer(Connection& connection) : m_connection(conne
 
 kj::Promise<void> ProxyServer<ThreadMap>::makeThread(MakeThreadContext context)
 {
-    std::string from = context.getParams().getName();
+    const std::string from = context.getParams().getName();
     std::promise<ThreadContext*> thread_context;
     std::thread thread([&thread_context, from, this]() {
         g_thread_context.thread_name = ThreadName(m_connection.m_loop.m_exe_name) + " (from " + from + ")";
diff --git a/src/mp/util.cpp b/src/mp/util.cpp
index f96598ee..d470375f 100644
--- a/src/mp/util.cpp
+++ b/src/mp/util.cpp
@@ -80,7 +80,7 @@ std::string LogEscape(const kj::StringTree& string)
     std::string result;
     string.visit([&](const kj::ArrayPtr<const char>& piece) {
         if (result.size() > MAX_SIZE) return;
-        for (char c : piece) {
+        for (const char c : piece) {
             if (c == '\\') {
                 result.append("\\\\");
             } else if (c < 0x20 || c > 0x7e) {
@@ -116,7 +116,7 @@ int SpawnProcess(int& pid, FdToArgsFn&& fd_to_args)
     }
     if (!pid) {
         // Child process must close all potentially open descriptors, except socket 0.
-        int maxFd = MaxFd();
+        const int maxFd = MaxFd();
         for (int fd = 3; fd < maxFd; ++fd) {
             if (fd != fds[0]) {
                 close(fd);

From 15c77e97226936dcb6f43681309347ae6ea3e211 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:33:15 +0000
Subject: [PATCH 07/14] clang-tidy: Fix `misc-include-cleaner` check

See: https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html
---
 example/calculator.cpp |  4 +++-
 example/example.cpp    |  9 ++++++++-
 example/printer.cpp    |  3 ++-
 src/mp/gen.cpp         | 11 +++++++++++
 src/mp/proxy.cpp       |  1 +
 src/mp/util.cpp        | 11 ++++++-----
 test/mp/test/test.cpp  |  9 ++++++++-
 7 files changed, 39 insertions(+), 9 deletions(-)

diff --git a/example/calculator.cpp b/example/calculator.cpp
index 26cc8088..2b9ec940 100644
--- a/example/calculator.cpp
+++ b/example/calculator.cpp
@@ -5,13 +5,15 @@
 #include <calculator.h>
 #include <fstream>
 #include <init.capnp.h>
-#include <init.capnp.proxy-types.h>
+#include <init.capnp.proxy.h> // NOLINT(misc-include-cleaner)
 #include <init.h>
 #include <iostream>
 #include <memory>
 #include <mp/proxy-io.h>
 #include <printer.h>
 #include <stdexcept>
+#include <string>
+#include <utility>
 
 class CalculatorImpl : public Calculator
 {
diff --git a/example/example.cpp b/example/example.cpp
index dcd6a68f..c7a233da 100644
--- a/example/example.cpp
+++ b/example/example.cpp
@@ -4,10 +4,17 @@
 
 #include <filesystem>
 #include <fstream>
+#include <future>
 #include <init.capnp.h>
-#include <init.capnp.proxy-types.h>
+#include <init.capnp.proxy.h>
 #include <iostream>
 #include <mp/proxy-io.h>
+#include <mp/util.h>
+#include <stdexcept>
+#include <string>
+#include <thread>
+#include <tuple>
+#include <vector>
 
 namespace fs = std::filesystem;
 
diff --git a/example/printer.cpp b/example/printer.cpp
index 6f2a4949..2a02cadc 100644
--- a/example/printer.cpp
+++ b/example/printer.cpp
@@ -4,13 +4,14 @@
 
 #include <fstream>
 #include <init.capnp.h>
-#include <init.capnp.proxy-types.h>
+#include <init.capnp.proxy.h> // NOLINT(misc-include-cleaner)
 #include <init.h>
 #include <iostream>
 #include <memory>
 #include <mp/proxy-io.h>
 #include <printer.h>
 #include <stdexcept>
+#include <string>
 
 class PrinterImpl : public Printer
 {
diff --git a/src/mp/gen.cpp b/src/mp/gen.cpp
index 66298346..396c73ef 100644
--- a/src/mp/gen.cpp
+++ b/src/mp/gen.cpp
@@ -7,11 +7,22 @@
 
 #include <algorithm>
 #include <capnp/schema-parser.h>
+#include <cstdint>
+#include <cstdio>
+#include <cstdlib>
 #include <errno.h>
 #include <fstream>
+#include <functional>
+#include <kj/array.h>
+#include <kj/common.h>
+#include <kj/filesystem.h>
+#include <kj/memory.h>
+#include <kj/string.h>
 #include <map>
 #include <set>
 #include <sstream>
+#include <stdexcept>
+#include <string>
 #include <system_error>
 #include <unistd.h>
 #include <vector>
diff --git a/src/mp/proxy.cpp b/src/mp/proxy.cpp
index 1bdc9b1a..a979410b 100644
--- a/src/mp/proxy.cpp
+++ b/src/mp/proxy.cpp
@@ -31,6 +31,7 @@
 #include <string>
 #include <sys/socket.h>
 #include <thread>
+#include <tuple>
 #include <unistd.h>
 #include <utility>
 
diff --git a/src/mp/util.cpp b/src/mp/util.cpp
index d470375f..691ae0b3 100644
--- a/src/mp/util.cpp
+++ b/src/mp/util.cpp
@@ -6,21 +6,22 @@
 #include <mp/util.h>
 
 #include <errno.h>
-#include <kj/array.h>
+#include <kj/common.h>
+#include <kj/string-tree.h>
 #include <pthread.h>
 #include <sstream>
 #include <stdio.h>
+#include <string>
 #include <sys/resource.h>
 #include <sys/socket.h>
-#include <sys/types.h>
-#include <sys/un.h>
 #include <sys/wait.h>
 #include <system_error>
-#include <thread>
 #include <unistd.h>
+#include <utility>
+#include <vector>
 
 #ifdef __linux__
-#include <syscall.h>
+#include <sys/syscall.h>
 #endif
 
 #ifdef HAVE_PTHREAD_GETTHREADID_NP
diff --git a/test/mp/test/test.cpp b/test/mp/test/test.cpp
index 661ae693..7721d41f 100644
--- a/test/mp/test/test.cpp
+++ b/test/mp/test/test.cpp
@@ -2,15 +2,22 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#include <mp/proxy-types.h>
+#include <mp/proxy-io.h>
 #include <mp/test/foo.capnp.h>
 #include <mp/test/foo.capnp.proxy.h>
 #include <mp/test/foo.h>
 
+#include <capnp/capability.h>
+#include <cstdio>
 #include <future>
+#include <functional>
+#include <memory>
 #include <kj/common.h>
 #include <kj/memory.h>
 #include <kj/test.h>
+#include <string>
+#include <thread>
+#include <utility>
 
 namespace mp {
 namespace test {

From c665a43f9c0fd058c86200d938ebeb373fa2289d Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:33:26 +0000
Subject: [PATCH 08/14] clang-tidy: Fix `misc-use-internal-linkage` check

See: https://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html
---
 example/calculator.cpp |  2 +-
 example/example.cpp    |  4 ++--
 example/printer.cpp    |  2 +-
 src/mp/gen.cpp         | 10 +++++-----
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/example/calculator.cpp b/example/calculator.cpp
index 2b9ec940..4290d687 100644
--- a/example/calculator.cpp
+++ b/example/calculator.cpp
@@ -32,7 +32,7 @@ class InitImpl : public Init
     }
 };
 
-void LogPrint(bool raise, const std::string& message)
+static void LogPrint(bool raise, const std::string& message)
 {
     if (raise) throw std::runtime_error(message);
     std::ofstream("debug.log", std::ios_base::app) << message << std::endl;
diff --git a/example/example.cpp b/example/example.cpp
index c7a233da..a4f84c55 100644
--- a/example/example.cpp
+++ b/example/example.cpp
@@ -18,7 +18,7 @@
 
 namespace fs = std::filesystem;
 
-auto Spawn(mp::EventLoop& loop, const std::string& process_argv0, const std::string& new_exe_name)
+static auto Spawn(mp::EventLoop& loop, const std::string& process_argv0, const std::string& new_exe_name)
 {
     int pid;
     const int fd = mp::SpawnProcess(pid, [&](int fd) -> std::vector<std::string> {
@@ -30,7 +30,7 @@ auto Spawn(mp::EventLoop& loop, const std::string& process_argv0, const std::str
     return std::make_tuple(mp::ConnectStream<InitInterface>(loop, fd), pid);
 }
 
-void LogPrint(bool raise, const std::string& message)
+static void LogPrint(bool raise, const std::string& message)
 {
     if (raise) throw std::runtime_error(message);
     std::ofstream("debug.log", std::ios_base::app) << message << std::endl;
diff --git a/example/printer.cpp b/example/printer.cpp
index 2a02cadc..ccaed689 100644
--- a/example/printer.cpp
+++ b/example/printer.cpp
@@ -25,7 +25,7 @@ class InitImpl : public Init
     std::unique_ptr<Printer> makePrinter() override { return std::make_unique<PrinterImpl>(); }
 };
 
-void LogPrint(bool raise, const std::string& message)
+static void LogPrint(bool raise, const std::string& message)
 {
     if (raise) throw std::runtime_error(message);
     std::ofstream("debug.log", std::ios_base::app) << message << std::endl;
diff --git a/src/mp/gen.cpp b/src/mp/gen.cpp
index 396c73ef..05589b12 100644
--- a/src/mp/gen.cpp
+++ b/src/mp/gen.cpp
@@ -75,7 +75,7 @@ static bool GetAnnotationInt32(const Reader& reader, uint64_t id, int32_t* resul
     return false;
 }
 
-void ForEachMethod(const capnp::InterfaceSchema& interface, const std::function<void(const capnp::InterfaceSchema& interface, const capnp::InterfaceSchema::Method)>& callback)
+static void ForEachMethod(const capnp::InterfaceSchema& interface, const std::function<void(const capnp::InterfaceSchema& interface, const capnp::InterfaceSchema::Method)>& callback)
 {
     for (const auto super : interface.getSuperclasses()) {
         ForEachMethod(super, callback);
@@ -89,7 +89,7 @@ using CharSlice = kj::ArrayPtr<const char>;
 
 // Overload for any type with a string .begin(), like kj::StringPtr and kj::ArrayPtr<char>.
 template <class OutputStream, class Array, const char* Enable = decltype(std::declval<Array>().begin())()>
-OutputStream& operator<<(OutputStream& os, const Array& array)
+static OutputStream& operator<<(OutputStream& os, const Array& array)
 {
     os.write(array.begin(), array.size());
     return os;
@@ -107,14 +107,14 @@ struct Format
     std::ostringstream m_os;
 };
 
-std::string Cap(kj::StringPtr str)
+static std::string Cap(kj::StringPtr str)
 {
     std::string result = str;
     if (!result.empty() && 'a' <= result[0] && result[0] <= 'z') result[0] -= 'a' - 'A';
     return result;
 }
 
-bool BoxedType(const ::capnp::Type& type)
+static bool BoxedType(const ::capnp::Type& type)
 {
     return !(type.isVoid() || type.isBool() || type.isInt8() || type.isInt16() || type.isInt32() || type.isInt64() ||
              type.isUInt8() || type.isUInt16() || type.isUInt32() || type.isUInt64() || type.isFloat32() ||
@@ -134,7 +134,7 @@ bool BoxedType(const ::capnp::Type& type)
 // include_prefix is "/a/b/c" include lines like
 // "#include <d/file.capnp.proxy.h>" "#include <d/file.capnp.proxy-types.h>"i
 // will be generated.
-void Generate(kj::StringPtr src_prefix,
+static void Generate(kj::StringPtr src_prefix,
     kj::StringPtr include_prefix,
     kj::StringPtr src_file,
     const std::vector<kj::StringPtr>& import_paths,

From 01ef094b4c291424e192fa32590d3991ca80316e Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:34:05 +0000
Subject: [PATCH 09/14] clang-tidy: Fix `performance-unnecessary-value-param`
 check

See: https://clang.llvm.org/extra/clang-tidy/checks/performance/unnecessary-value-param.html
---
 include/mp/proxy-io.h | 4 ++--
 src/mp/proxy.cpp      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h
index aeb987c8..70b01971 100644
--- a/include/mp/proxy-io.h
+++ b/include/mp/proxy-io.h
@@ -63,7 +63,7 @@ struct ProxyClient<Thread> : public ProxyClientBase<Thread, ::capnp::Void>
     ProxyClient(const ProxyClient&) = delete;
     ~ProxyClient();
 
-    void setCleanup(std::function<void()> fn);
+    void setCleanup(const std::function<void()>& fn);
 
     //! Cleanup function to run when the connection is closed. If the Connection
     //! gets destroyed before this ProxyClient<Thread> object, this cleanup
@@ -523,7 +523,7 @@ using ConnThread = ConnThreads::iterator;
 // Retrieve ProxyClient<Thread> object associated with this connection from a
 // map, or create a new one and insert it into the map. Return map iterator and
 // inserted bool.
-std::tuple<ConnThread, bool> SetThread(ConnThreads& threads, std::mutex& mutex, Connection* connection, std::function<Thread::Client()> make_thread);
+std::tuple<ConnThread, bool> SetThread(ConnThreads& threads, std::mutex& mutex, Connection* connection, const std::function<Thread::Client()>& make_thread);
 
 struct ThreadContext
 {
diff --git a/src/mp/proxy.cpp b/src/mp/proxy.cpp
index a979410b..7c26702e 100644
--- a/src/mp/proxy.cpp
+++ b/src/mp/proxy.cpp
@@ -281,7 +281,7 @@ bool EventLoop::done(std::unique_lock<std::mutex>& lock)
     return m_num_clients == 0 && m_async_fns.empty();
 }
 
-std::tuple<ConnThread, bool> SetThread(ConnThreads& threads, std::mutex& mutex, Connection* connection, std::function<Thread::Client()> make_thread)
+std::tuple<ConnThread, bool> SetThread(ConnThreads& threads, std::mutex& mutex, Connection* connection, const std::function<Thread::Client()>& make_thread)
 {
     const std::unique_lock<std::mutex> lock(mutex);
     auto thread = threads.find(connection);
@@ -316,7 +316,7 @@ ProxyClient<Thread>::~ProxyClient()
     }
 }
 
-void ProxyClient<Thread>::setCleanup(std::function<void()> fn)
+void ProxyClient<Thread>::setCleanup(const std::function<void()>& fn)
 {
     assert(fn);
     assert(!m_cleanup_it);

From 4abaa9842922c5de7ef8955673ca4e0ec24ba462 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:34:19 +0000
Subject: [PATCH 10/14] clang-tidy: Fix
 `readability-avoid-nested-conditional-operator` check

See: https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-nested-conditional-operator.html
---
 src/mp/gen.cpp | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/mp/gen.cpp b/src/mp/gen.cpp
index 05589b12..bdbee4b0 100644
--- a/src/mp/gen.cpp
+++ b/src/mp/gen.cpp
@@ -214,8 +214,11 @@ static void Generate(kj::StringPtr src_prefix,
     cpp_types << "namespace mp {\n";
 
     std::string guard = output_path;
-    std::transform(guard.begin(), guard.end(), guard.begin(), [](unsigned char c) {
-        return ('0' <= c && c <= '9') ? c : ('A' <= c && c <= 'Z') ? c : ('a' <= c && c <= 'z') ? c - 'a' + 'A' : '_';
+    std::transform(guard.begin(), guard.end(), guard.begin(), [](unsigned char c) -> unsigned char {
+        if ('0' <= c && c <= '9') return c;
+        if ('A' <= c && c <= 'Z') return c;
+        if ('a' <= c && c <= 'z') return c - 'a' + 'A';
+        return '_';
     });
 
     std::ofstream inl(output_path + ".proxy-types.h");
@@ -495,7 +498,13 @@ static void Generate(kj::StringPtr src_prefix,
                     auto field_type = f.getType();
 
                     std::ostringstream field_flags;
-                    field_flags << (!field.param_is_set ? "FIELD_OUT" : field.result_is_set ? "FIELD_IN | FIELD_OUT" : "FIELD_IN");
+                    if (!field.param_is_set) {
+                        field_flags << "FIELD_OUT";
+                    } else if (field.result_is_set) {
+                        field_flags << "FIELD_IN | FIELD_OUT";
+                    } else {
+                        field_flags << "FIELD_IN";
+                    }
                     if (field.optional) field_flags << " | FIELD_OPTIONAL";
                     if (field.requested) field_flags << " | FIELD_REQUESTED";
                     if (BoxedType(field_type)) field_flags << " | FIELD_BOXED";

From 68c1c6c51a1bbf029d345b4258caf7439a4f5254 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:34:36 +0000
Subject: [PATCH 11/14] clang-tidy: Fix
 `readability-avoid-return-with-void-value` check

See: https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-return-with-void-value.html

Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
---
 include/mp/proxy-io.h | 2 +-
 src/mp/proxy.cpp      | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h
index 70b01971..38622cf6 100644
--- a/include/mp/proxy-io.h
+++ b/include/mp/proxy-io.h
@@ -152,7 +152,7 @@ class EventLoop
     template <typename Callable>
     void sync(Callable&& callable)
     {
-        return post(std::ref(callable));
+        post(std::ref(callable));
     }
 
     //! Start asynchronous worker thread if necessary. This is only done if
diff --git a/src/mp/proxy.cpp b/src/mp/proxy.cpp
index 7c26702e..f1b51115 100644
--- a/src/mp/proxy.cpp
+++ b/src/mp/proxy.cpp
@@ -221,7 +221,8 @@ void EventLoop::loop()
 void EventLoop::post(const std::function<void()>& fn)
 {
     if (std::this_thread::get_id() == m_thread_id) {
-        return fn();
+        fn();
+        return;
     }
     std::unique_lock<std::mutex> lock(m_mutex);
     m_cv.wait(lock, [this] { return m_post_fn == nullptr; });

From 593807ab5b265f95d6e49fdc219d739e1e234f5f Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:34:46 +0000
Subject: [PATCH 12/14] clang-tidy: Fix `readability-container-size-empty`
 check

See: https://clang.llvm.org/extra/clang-tidy/checks/readability/container-size-empty.html
---
 include/mp/proxy-io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h
index 38622cf6..02d0dee0 100644
--- a/include/mp/proxy-io.h
+++ b/include/mp/proxy-io.h
@@ -488,7 +488,7 @@ ProxyServerBase<Interface, Impl>::~ProxyServerBase()
             CleanupRun(fns);
         });
     }
-    assert(m_context.cleanup_fns.size() == 0);
+    assert(m_context.cleanup_fns.empty());
     std::unique_lock<std::mutex> lock(m_context.connection->m_loop.m_mutex);
     m_context.connection->m_loop.removeClient(lock);
 }

From a02c0794fd9af8a99cc3e8a75984ffc567e2cb50 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Fri, 31 Jan 2025 23:35:06 +0000
Subject: [PATCH 13/14] clang-tidy: Suppress `performance-enum-size` check
 warning

See: https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html

Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
---
 test/mp/test/foo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/mp/test/foo.h b/test/mp/test/foo.h
index ceb8dcc2..1c5ee79f 100644
--- a/test/mp/test/foo.h
+++ b/test/mp/test/foo.h
@@ -21,7 +21,7 @@ struct FooStruct
     std::vector<bool> vbool;
 };
 
-enum class FooEnum : int { ONE = 1, TWO = 2, };
+enum class FooEnum : uint8_t { ONE = 1, TWO = 2, };
 
 struct FooCustom
 {

From 0b8b7f92ca39d01f1422bfdbbbf55fb92857b7b9 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Tue, 4 Feb 2025 19:00:40 +0000
Subject: [PATCH 14/14] refactor: Fix `-Wsign-compare` compiler warning

Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
---
 src/mp/gen.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mp/gen.cpp b/src/mp/gen.cpp
index bdbee4b0..c4d9a516 100644
--- a/src/mp/gen.cpp
+++ b/src/mp/gen.cpp
@@ -650,7 +650,7 @@ int main(int argc, char** argv)
     } else {
         throw std::runtime_error(std::string("Failed to open src_prefix prefix directory: ") + argv[1]);
     }
-    for (size_t i = 4; i < argc; ++i) {
+    for (int i = 4; i < argc; ++i) {
         KJ_IF_MAYBE(dir, fs->getRoot().tryOpenSubdir(cwd.evalNative(argv[i]))) {
             import_paths.emplace_back(argv[i]);
             import_dirs.emplace_back(kj::mv(*dir));