Add ability to pass extra entropy to rfc6979#229
Merged
sipa merged 2 commits intobitcoin-core:masterfrom Mar 27, 2015
Merged
Conversation
Contributor
|
I've sent email to Thomas Pornin on the question of exactly how the 3.6 "additional data" was supposed to be applied with respect to steps 3.2.d vs 3.2.f in the draft. I believe all solutions are likely to be adequate but for consistency I thought it would be good to clarify whats intended in the draft. |
Suggested by Greg Maxwell.
Contributor
Author
|
Updated to apply it both 3.2.d and 3.2.f. |
Contributor
|
ACK with https://people.xiph.org/~greg/0001-Add-a-simple-testcase-for-signing-with-rfc6979-extra.patch or something substantially similar added. :) (could you imagine if some (future) typo made the extra data blow away the other inputs to the 6979? ouch!) |
Contributor
Author
|
Included your commit. |
Contributor
Author
|
ACK extra commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by Greg Maxwell.