Remove unused secp256k1_fe_inv_all_var #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
cr ACK 75d2ae1: patch looks correct |
|
utACK 75d2ae1 @practicalswift What's a "cr ACK"? |
jonasnick
reviewed
Jan 25, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 8, 2021
Summary: ``` This function is only used in tests, since its functionality was inlined into secp256k1_ge_set_all_gej_var in #553. ``` Backport of [[bitcoin-core/secp256k1#878 | secp256k1#878]] Test Plan: ninja check-secp256k1 Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D9384
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Apr 9, 2021
Summary: ``` This function is only used in tests, since its functionality was inlined into secp256k1_ge_set_all_gej_var in #553. ``` Backport of [[bitcoin-core/secp256k1#878 | secp256k1#878]] Test Plan: ninja check-secp256k1 Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D9384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is only used in tests, since its functionality was inlined into
secp256k1_ge_set_all_gej_varin #553.Closes #873.