Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

opcode or "op code"? #1068

Closed
laanwj opened this Issue Sep 23, 2015 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

laanwj commented Sep 23, 2015

In the developer reference we refer to "op codes" or "OP codes":

In what I've read before, e.g. assembly manuals, the word was always "opcodes". Wikipedia seems to confirm this https://en.wikipedia.org/wiki/Opcode same for the bitcoin wiki: https://en.bitcoin.it/wiki/Script

Is there a specific reason to put it as two words?

Contributor

harding commented Sep 25, 2015

The reason that it's two words is that I didn't know it should be one word. I'll open a PR to fix it as soon as a get a chance. Thanks!

@harding harding added the Dev Docs label Sep 25, 2015

@harding harding self-assigned this Sep 25, 2015

Contributor

laanwj commented Sep 28, 2015

If everyone agrees this is the way forward I'm willing to make the changes as well

Contributor

carnesen commented Sep 28, 2015

I did a lil Googling on the subject and "opcode" does seem to be more
standard than "op code".

On Mon, Sep 28, 2015 at 1:26 PM Wladimir J. van der Laan <
notifications@github.com> wrote:

If everyone agrees this is the way forward I'm willing to make the changes
as well


Reply to this email directly or view it on GitHub
#1068 (comment)
.

Contributor

harding commented Sep 28, 2015

I think there are some images that need to be updated too, which might be easier for me to do (the images are all generated with GraphViz). However, if someone wants to do a quick s/// on the _includes directory, we can get that merged quickly and clean up any edge cases later.

harding added a commit to harding/bitcoin.org that referenced this issue Oct 23, 2015

Contributor

harding commented Oct 23, 2015

#1107 makes this change. Thanks for the suggestion!

@harding harding closed this in 64e4c54 Oct 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment