Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
App popups unreadable on mobile page #113
Comments
|
Strangely, on Android at least, it is possible to scroll when the bubble overflow on the right side (it would work with Armory) but it doesn't work with the left side (Bitcoin-Qt). Meanwhile as a simple workaround, it is possible to see the bubble by turning your mobile horizontally (landscape). |
|
I'd suggest removing the popups completely and just list all the clients. Makes it much easier to see which client is available for an specific OS, too. |
|
@tcatm : You mean, only show the mobile apps from the mobile website with no bubble, and keep the rest as it is for desktops? |
|
Nope, just show a list (maybed with tabs for each category) of all apps. |
|
I was afraid that this approach would either be limitative, or not scale well and become heavy loaded and less consistent (especially if we have more wallets in the future). It also would not allows us to explain each wallet category very well and we would miss explanations about webwallet, I think those are important for a new visitor. Since most wallet apps are available for all operating systems, I thought it was a greater priority to have a consistent layout that could scale with a clear division between each category. |
|
Also, the un-hiding of web-wallets does not work on Chromium / Android. Nothing happens if I click on "OK". |
|
This one should be fairly easy to fix. Thanks for reporting. |
|
@schildbach Since you are currently testing, what happens if you replace all
by
in choose-your-wallet.html |
|
AFAICT doesn't work. But better try it yourself - I'm not sure if my local environment can test this - e.g. the issue with the missing URL rewriting. |
|
If forgot to mention that this fix targets the "impossible to un-hide the web-wallets" issue. Is it the issue you tested? If that's the case, I'm puzzled.. As it works well in default Android 2.3 browser and Chrome on desktop. |
|
Yes, that's the one I tested. I just tried the old Android browser, which is still around on Android 4.2. On that browser, un-hiding works. However, the whole layout is broken because it is not detected as a mobile browser. |
|
Firefox for Android is also not detected correctly. |
|
I've just installed Firefox for Android, tested current bitcoin.org.. and it worked perfectly in my case.. I bet that it is related to the resolution of the device. Current CSS tries to detect mobile based on handheld or resolutions lower than 700px : @media handheld, only screen and (max-device-width:700px) { |
|
Meanwhile, there seems to be too much "apparently impossible to fix" issues for this page. Therefore, since its content is not as relevant on mobile and as suggested by a few, I choosed to hide this part of the website. Issues are described in the commit in case someone have genius ideas and want to work on this. But it seems rather complicate, especially because of the "display hidden wallet" part. 68d6e91 It might make more sense to auto-detect and show Bitcoin Wallet / Android or Blockchain / iPhone in the "Get started fast and easy" in the future. |

schildbach commentedApr 3, 2013
They are cut off at either left or right side, with no way to pan or zoom.
See picture.
![Uploading device-2013-04-03-190224.png . . .]()