/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Typo in block version header data type? #1413

Closed
axvm opened this Issue Nov 19, 2016 · 4 comments

Comments

Assignees

@wbnns wbnns

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axvm @MarcoFalke @wbnns
@axvm
Contributor

axvm commented Nov 19, 2016

Hello,

Developer reference says version header data type is uint32 but as @fanatid mention in bitcoinjs/bitcoinjs-lib#712
protocol documentation says version header datatype is signed int32.

I'd like to know who is right. Thanks.

Source File: _includes/devdoc/ref_block_chain.md
@axvm
Contributor

axvm commented Nov 19, 2016

There is definitely a typo in developer reference because nVersion declared as signed int32 in official client.
@MarcoFalke
Contributor

MarcoFalke commented Nov 19, 2016

@axvm Pull request welcome

@axvm axvm referenced this issue in axvm/bitcoin.org Nov 19, 2016

Closed

Changed version data type to signed int32 #1

@axvm
Contributor

axvm commented Nov 19, 2016

@MarcoFalke done. Let me know if I need to change something in pr.

@axvm axvm referenced this issue Nov 20, 2016

Merged

Changed version data type to signed int32 #1414

@axvm
Contributor

axvm commented Nov 20, 2016 • edited

Made PR to correct repo.

@wbnns wbnns self-assigned this Dec 9, 2016

@wbnns wbnns closed this Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment