Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

"ListSinceBlock" docs wrong? #1457

Closed
wyager opened this Issue Dec 23, 2016 · 3 comments

Comments

Projects
None yet
3 participants

wyager commented Dec 23, 2016

Source File: _includes/devdoc/bitcoin-core/rpcs/rpcs/listsinceblock.md

The doc field for "blockindex" says "Only returned for confirmed transactions. The block height of the block on the local best block chain which includes this transaction". I'm pretty sure this is wrong; from my end, it looks like "blockindex" is actually the index of the transaction within the block. I'm getting values below a couple thousand, whereas at least the block hash seems correct.

Contributor

Mirobit commented Dec 25, 2016

Same problem here: #1237.

I have a branch that fixes a few things in helpers/vars.md (including blockindex). Pull request will follow soon.

@wbnns wbnns self-assigned this Dec 26, 2016

Contributor

Mirobit commented Jan 7, 2017

Thanks, addressed in 9c9edae

wyager commented Jan 7, 2017

Cheers, closing.

@wyager wyager closed this Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment