/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ping nonce protocol version inconsistent. #1548

Closed
evoskuil opened this Issue Mar 21, 2017 · 1 comment

Comments

Assignees

@wbnns wbnns

Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
2 participants
@evoskuil @wbnns
@evoskuil
Contributor

evoskuil commented Mar 21, 2017

Source File: _includes/devdoc/ref_p2p_networking.md

This selected text:

Added in protocol version 60000 as described by BIP31.

... is inconsistent with the preceding text, BIP31 and this section. Should read 60001.

@wbnns wbnns self-assigned this Mar 21, 2017

@wbnns wbnns added the Under Review label Mar 21, 2017

@wbnns wbnns referenced this issue Mar 22, 2017

Merged

ref_p2p_networking: Fix protocol version #1549

@wbnns wbnns added Merge Scheduled and removed Under Review labels Mar 22, 2017

@wbnns
Contributor

wbnns commented Mar 22, 2017

@evoskuil Hello, thanks for catching this and bringing it to attention. Just submitted PR #1549 which will resolve the issue.

@wbnns wbnns closed this in #1549 Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment