Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Headers message may be empty. #1604

Closed
evoskuil opened this Issue May 18, 2017 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

evoskuil commented May 18, 2017

Source File: _includes/devdoc/ref_p2p_networking.md

This statement implies that empty headers messages are not sent, which is not the case:

The headers message sends one or more block headers to a node which previously requested certain headers with a getheaders message.

It is typical for peers to send an empty headers message in response when the peers are in sync.

@wbnns wbnns self-assigned this May 19, 2017

Contributor

wbnns commented May 21, 2017

Bounty: 5,000 bits / ~$10 USD

Contributor

evoskuil commented May 22, 2017 edited

This issue may apply to the description of the INV message as well, though I haven't verified the behavior.

@wbnns wbnns closed this May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment