Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Consider Including a Warning for Bitcoin's Merkle Tree #1613
Comments
wbnns
self-assigned this
May 26, 2017
wbnns
added
the
Under Review
label
May 26, 2017
|
@tommagnusson I think we already have a warning in that section: I admit, that's a bit wordy and could be improved. |
wbnns
closed this
Jun 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment

tommagnusson commentedMay 26, 2017
Location: https://bitcoin.org/en/developer-guide#transaction-data
In the source code for bitcoin's merkle tree implementation there exists a large warning comment explaining a security vulnerability: https://github.com/bitcoin/bitcoin/blob/master/src/consensus/merkle.cpp#L22
Perhaps consider adding a similar warning in the documentation on the website, because it appears to be a naive way of constructing a merkle tree.