Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Consider Including a Warning for Bitcoin's Merkle Tree #1613

Closed
tommagnusson opened this Issue May 26, 2017 · 1 comment

Comments

Projects
None yet
3 participants

Location: https://bitcoin.org/en/developer-guide#transaction-data

In the source code for bitcoin's merkle tree implementation there exists a large warning comment explaining a security vulnerability: https://github.com/bitcoin/bitcoin/blob/master/src/consensus/merkle.cpp#L22

Perhaps consider adding a similar warning in the documentation on the website, because it appears to be a naive way of constructing a merkle tree.

@wbnns wbnns self-assigned this May 26, 2017

@wbnns wbnns added the Under Review label May 26, 2017

Contributor

harding commented May 31, 2017

@tommagnusson I think we already have a warning in that section:

2017-05-31-13_25_07_844885508

I admit, that's a bit wordy and could be improved.

@wbnns wbnns closed this Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment