Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Events page no longer displays Bitcoin meetups #1617
Comments
|
ACK |
|
@harding Hey, nice catch! Thanks! Agreed and sounds good to me. |
wbnns
self-assigned this
Jun 2, 2017
harding
added a commit
to harding/bitcoin.org
that referenced
this issue
Jun 3, 2017
harding
referenced this issue
Jun 3, 2017
Merged
Events plugin: stop requesting events from Meetup.com #1620
wbnns
closed this
in
#1620
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
harding commentedMay 31, 2017
I was tracing down another issue and I noticed the that Meetup API was failing for us. It appears that they've changed to requiring an API key. Here's the URL we currently use:
http://api.meetup.com/2/open_events?omit=description&status=upcoming&radius=25.0&topic=bitcoin&and_text=False&limited_events=False&desc=False&offset=0&format=json&page=500&time=0m%2C3m&sig_id=133622112&sig=cd874bc2c84f96d989f823880889bda2f5e4cdc5
And here's what it says when accessed:
Fixing this would be kind of annoying because we wouldn't want to put the access key in the code itself (we'd probably use an environmental variable accessible on the server), but if we don't put the key in the code itself, we can't test with Travis CI or on any random contributor's machine. Not that testing actually caught this bug whenever it started to fail.
I think the current events page is just fine without the meetups (and we do have a working link to Bitcoin meetups on the bottom of that page), so I suggest that we just drop that part of the events plugin. (I suspect my other issue is in that part of the code also.) I'm happy to make and test that change if there's agreement on that being a reasonable path forward.