Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Web wallets are displayed when Mobile is selected #1743

Closed
crwatkins opened this Issue Aug 12, 2017 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

crwatkins commented Aug 12, 2017 edited by wbnns

Bounty: 20,000 bits / ~$90 USD

@kuzzmi

On desktop Chrome browser

  1. Go to https://bitcoin.org/en/choose-your-wallet
  2. Click on Web: See Web selected, and see listing of wallets
  3. Click on Mobile (but do not select any of the platforms): See Mobile menu selected

Expected: The listing would show Mobile wallets, or the menu selection would remain on Web
Observed: The listing still shows Web wallets, but Mobile menu is selected.

Same occurs when clicking on Desktop but not selecting any of the platforms.

Contributor

kuzzmi commented Aug 12, 2017

I'm actually in doubt whether it even makes sense to show "all mobile" wallets. If I'm interested in the mobile wallet, I already know OS I'm looking a wallet for.

This is definitely a bug, but a way to fix it I see is a bit different. I think it makes more sense to disable clicking a top-level menu item if there are sub-items already.
This is a general issue with menus (I clicked on "Resources"):

image

Contributor

crwatkins commented Aug 12, 2017

@kuzzmi I agree.

@wbnns wbnns added the Under Review label Aug 12, 2017

@wbnns wbnns self-assigned this Aug 12, 2017

@wbnns wbnns added Bounty Wallets and removed Under Review labels Sep 17, 2017

@wbnns wbnns closed this in #1816 Oct 8, 2017

wbnns added a commit that referenced this issue Oct 8, 2017

Merge pull request #1816 from kuzzmi/fix-wallets-menu
Fixes issue with wallets and head menu (#1743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment