Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add Hive/Electrum to the "choose your wallet" page #293

Closed
mikehearn opened this Issue Jan 5, 2014 · 8 comments

Comments

Projects
None yet
4 participants
Contributor

mikehearn commented Jan 5, 2014

The latest beta of Hive adds support for wallet encryption and backup. It still has a few glitches, but I guess that soon it will be pretty much "Ready to go" (for mac users only). The current release probably shouldn't be listed on the site, as the website says it's still in beta. But I'm hoping the Hive team will do a v1.0 soon. It's based on the latest bitcoinj which has proven stable in recent months for other wallets.

Electrum has changed over time so it's now much closer to bitcoinj, security wise: it queries multiple servers for block chain headers and checks Merkle branches from those servers. This gives basically the SPV security model, although it has only a handful of servers to choose from vs the P2P network. So I feel the original rationale for putting Electrum down in a box area at the bottom no longer holds true.

IMHO, both these wallets should be listed up with MultiBit and the Android wallet at the top. I don't know if we should use magic JavaScript to hide/grey out Hive for non-Mac users. Also, I wonder if we should bring back screenshots like we used to have on the old website for wallets that are "featured" up at the top. Otherwise it may be a bit hard to choose between them. People can get "paralyzed by choice" because it'd be unclear which wallet they should investigate first: giving a nice picture can help resolve this, even though it's a somewhat arbitrary way to make a decision.

Contributor

luke-jr commented Jan 5, 2014

NACK Electrum, since it's presenting a confused GUI now ("Send from" nonsense).

I believe Hive's next version is eliminating most of the "sending address" nonsense, so may be worth considering.

@ghost

ghost commented Jan 5, 2014

CC: @jsuder @tgerring @nschum

Contributor

saivann commented Jan 6, 2014

Hive : I think waiting one month after v1.0 is released would make sense. I generally agree with @luke-jr about "Send from" addresses in GUI, although maybe as suggested on #277, it would be better for the community to agree on a set of reasonable criteria before working on them / asking for them.

Electrum / Top listing : I'm not convinced about displaying many wallets at the top, because the purpose was to suggest only one wallet so the lazy visitor doesn't need to choose. However, giving more visibility to Electrum now seems more interesting (I'll open a seperate pull req). Screenshots is an interesting idea.

@luke-jr : I've just tested Electrum and what you're refering to seems to have been fixed. Electrum 1.9.3 shows the "Received with" address in the description list, and transaction details shows inputs and outputs. Electrum v1.0 did have the problem however, according to some older screenshots.

Contributor

saivann commented May 13, 2014

Closing this issue as the "Electrum/Hive" issues are fixed. I've taken note of remaining feedback.

@saivann saivann closed this May 13, 2014

mackuba commented May 13, 2014

How do you handle translations? It looks like in some language versions Hive is there, and in some it's missing.

Contributor

saivann commented May 13, 2014

@jsuder It is expected that Hive (or any text addition) will only appear as soon as translations are complete on Transifex and updated on the website. https://github.com/bitcoin/bitcoin.org#translation

@ghost

ghost commented May 14, 2014

One more thing: Should we open a separate ticket about adding this?
http://www.coindesk.com/hive-launches-android-bitcoin-wallet-built-app-store/

After a decent testing period we would love to link that up as well.

Contributor

saivann commented May 14, 2014

@w-hive Yes, please open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment