Revert removal of icon padding

[schildbach]

See discussion: d2f695c

[harding]

I didn't notice it before @schildbach mentioned it, but when I zoom in on the webpage itself, all the round icons on the Desktop screen do look like a few pixels of their right edge has been cropped off.

I have no comment in general on whether or not the icons should be padded.

[saivann]

@harding This could be an issue with CSS, although I can't reproduce this behavior here. The icon itself doesn't have any pixels missing.

As far as I'm concerned, I think both ways work just fine, but using icons without extra padding is just simplier (e.g. new wallets being submitted will less likely need changes to the icon, less image editing, icons have smaller size, etc).

[schildbach]

It seems to be harder for people to exactly hit the right size. Just have a look at all the junk icons on Google Play which have cut pixels on several sides, cut off shadows etc. So I expect more work, rather than less. Especially if you use a shadow. It's hard to define a boundary around a shadow because naturally there is none.

But most important, it's not possible to achieve consistent visual sizes when mixing icons with and without shadow.

[harding]

@saivann You're right; it looks like it was the original images which are either overcropped or which just lacked shadow at the top, bottom, left, and right edges. Compare the Bitcoin Core icon to the Bitcoin Wallet For Android both at 144px in GIMP using the magic select tool at 0.0 with quick mask on:

Blocky Bitcoin Core:

Smoother Bitcoin Wallet For Android:

Anyway, I have trouble even color coordinating my clothes, so I'll leave the rest of this graphics design debate up to you experts. :-)

[saivann]

@harding :-)

@schildbach You seem to really want it reverted, so unless we get comments in favor of the current icons, I will take care to revert this & change images path again (maybe after Hive/KnC are merged). Thanks for explaining your point, and sorry for the change; I wasn't aware this padding was intended.

[schildbach]

Well at least I think there is a strong point for having a padding, although we can maybe reduce it from the original padding. The original padding was (144-96)/2 = 24px. We could halve it to 12px, so the total image size would be 96+12*2 = 120px. Though I'm not sure if the bytes saved are worth the trouble…

I just checked bitcoincore.png, electrum.png and bitgo.png and all of them have been cut into their 2-6 pixels very subtle shadow. So I indeed think we should revert the change completely. Thanks @harding for point me to the fuzzy select tool!

[saivann]

Indeed I'll just restore previous icons, it think it's just fine. Regarding the very subtle cropping, I am barely able to notice it and the 144px icons had the same issue, so I'll just restore them. But if someone cares enough to try improving them afterwhile, patches welcome.