Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Incorrect reference to offline wallet in developers guide #835
Comments
harding
closed this
in
31bf3d8
Apr 20, 2015
|
@cbaumler thanks! I implemented your suggested fix; it should appear on the website within about 15 minutes. Thanks again! |
cbaumler
commented
Apr 20, 2015
|
No problem. Thanks for providing this excellent developer guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cbaumler commentedApr 20, 2015
Source File: _includes/guide_wallets.md
The developers guide refers to an offline wallet when it should be referring to a signing-only wallet for consistency.
Original text:
After the optional review step, the offline wallet uses the parent private key to derive the appropriate child private keys and signs the transactions, giving the signed transactions back to the networked wallet.
Suggested revision:
After the optional review step, the signing-only wallet uses the parent private key to derive the appropriate child private keys and signs the transactions, giving the signed transactions back to the networked wallet.