Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Apply more graceful mobile stylesheet to landing page icons #1016

Merged
merged 2 commits into from Aug 21, 2015

Conversation

Projects
None yet
3 participants
Contributor

saivann commented Aug 20, 2015

This addresses at least one issue mentioned on #1014 , by allowing these elements to be displayed inline on the screen until the space is really stretch enough.

I should have left equivalent space for texts, so variable-width translations should still fit correctly in the available space. At least I have verified various ones without noticing any issue.

Live preview: (Merged)

Contributor

harding commented Aug 20, 2015

LGTM. Thanks!

Contributor

saivann commented Aug 20, 2015

In the absence of critical feedback, this pull request will be merged on August 21th (tomorrow).

Contributor

carnesen commented Aug 20, 2015

Yup, good one! Preview looks good now even at 175%.

Contributor

saivann commented Aug 20, 2015

@carnesen Thanks for reporting the issue!

Contributor

saivann commented Aug 21, 2015

Note; I just added some changes to the CSS for the RTL and IE6 layouts to provide them with the same display, the live preview will be updated in a minute.

Contributor

harding commented Aug 21, 2015

utACK af646e4

@saivann saivann merged commit af646e4 into bitcoin-dot-org:master Aug 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saivann saivann deleted the saivann:fix-landing-page-icons branch Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment