Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add JSHint checks to the Makefile #1018

Merged
merged 3 commits into from Aug 22, 2015

Conversation

Projects
None yet
2 participants
Contributor

saivann commented Aug 21, 2015

Live preview: (Merged)

If we're to add more javascript code to the website, this can help encourage a strict syntax and catch mistakes (I actually found and fixed one bug while preparing this pull request).

JSHint is configured to check only custom javascript files in js/ (not libraries) and uses the default configuration with a few relaxed tests.

Contributor

harding commented Aug 21, 2015

Tested ACK: built & tested locally; checked HTML diff; browsed several update pages & checked JS functions. Also reviewed code.

Note that this PR will create a merge conflict with #1009. I suggest you merge this first and I'll rebase on top of it.

When you merge, the bundle on the build server should be automatically updated (it worked the last two times the Gemfile was changed) but I suggest that you monitor it just in case.

Finally, thanks! This will be really useful particularly for me, since I write JS so infrequently.

Contributor

saivann commented Aug 21, 2015

@harding Wow, thanks for your fast testing! Indeed, I planned to watch the live update closely when I will merge this pull request.

In the absence of critical feedback, this pull request will be merged on August 22th.

@saivann saivann merged commit d1efe4d into bitcoin-dot-org:master Aug 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saivann saivann deleted the saivann:jshint branch Aug 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment