Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow code samples to overflow on mobiles in the documentation #1019

Merged
merged 1 commit into from Aug 23, 2015

Conversation

Projects
None yet
3 participants
Contributor

saivann commented Aug 21, 2015

Live preview: (Merged)

Some code samples cannot be read on mobiles. Although this solution isn't ideal as it makes the code overflow outside of the page, my impression is that it's better than cutting the content altogether.

Contributor

harding commented Aug 22, 2015

Tested ACK using Android 2.3.5 for mobile and FF 31.8 for desktop. Overflowing on mobile is indeed much better, thanks!

Contributor

saivann commented Aug 22, 2015

@harding Thanks!

In the absence of critical feedback, this pull request will be merged on August 23th.

Contributor

carnesen commented Aug 22, 2015

Tested on Chrome on iOS and desktop. Is better indeed, thanks.

On Fri, Aug 21, 2015 at 10:24 PM saivann notifications@github.com wrote:

@harding https://github.com/harding Thanks!

In the absence of critical feedback, this pull request will be merged on
August 23th.


Reply to this email directly or view it on GitHub
#1019 (comment)
.

@saivann saivann merged commit 304bd1f into bitcoin-dot-org:master Aug 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saivann saivann deleted the saivann:show-code branch Aug 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment