Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Allow code samples to overflow on mobiles in the documentation #1019
Conversation
|
Tested ACK using Android 2.3.5 for mobile and FF 31.8 for desktop. Overflowing on mobile is indeed much better, thanks! |
|
@harding Thanks! In the absence of critical feedback, this pull request will be merged on August 23th. |
saivann
added
the
Merge Scheduled
label
Aug 22, 2015
|
Tested on Chrome on iOS and desktop. Is better indeed, thanks. On Fri, Aug 21, 2015 at 10:24 PM saivann notifications@github.com wrote:
|
saivann commentedAug 21, 2015
Live preview: (Merged)
Some code samples cannot be read on mobiles. Although this solution isn't ideal as it makes the code overflow outside of the page, my impression is that it's better than cutting the content altogether.