Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow build script to reuse pre-installed dependencies #1020

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

saivann commented Aug 22, 2015

Currently, our build script needs to download and install dependencies on every build. This probably prolongs build time unnecessarily and introduces a bit more of security risk with no apparent benefit.

This little change allows the build script to stop deleting files listed in .gitignore when fetching recent commits, therefore allowing it to keep and reuse the bundle environment in ./vendor.

Note: This small change is untested.

Contributor

harding commented Aug 22, 2015

@saivann I thought we fixed that in #939 ?

Contributor

saivann commented Aug 22, 2015

@harding Duh, obviously! Thanks, I somehow assumed that the build was still using the ./vendor path, and I guessed that I had only thought about the issue without opening a PR in the past... I should have looked more.

@saivann saivann closed this Aug 22, 2015

@saivann saivann deleted the saivann:pre-installed-dependencies branch Aug 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment