Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updates Ninki Wallet description #1034

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

Ninkip2p commented Aug 28, 2015

No description provided.

@harding harding commented on the diff Aug 28, 2015

_translations/en.yml
@@ -187,7 +187,7 @@ en:
wallettrezor: "Trezor is a hardware wallet providing a high level of security without sacrificing convenience. Unlike cold storage, Trezor is able to sign transactions while connected to an online device. That means spending bitcoins is secure even when using a compromised computer."
walletcopay: "Copay is the HD-multisignature wallet originally built to secure BitPay's funds. Copay supports multiple personal and shared wallets, testnet, and the full Payment Protocol. A private <a href=\"https://github.com/bitpay/bitcore-wallet-service\">BWS</a> node can be used for enhanced security and privacy."
walletnano: "Ledger Nano is a hardware wallet built upon a ST23YT66 banking smartcard platform. It keeps the user private keys safe, validates transactions, can be used as a secure prepaid card or a multisignature party. While not open-source, it can be deterministically validated."
- walletninki: "Ninki is a multi-signature wallet with a beautiful user interface that makes sending bitcoin as easy as email. You have full control of your bitcoins at all times."
+ walletninki: "For experienced Bitcoin users. Ninki is a multi-signature wallet with a beautiful user interface. You have full control of your bitcoins at all times."
@harding

harding Aug 28, 2015

Contributor

ACK this change.

@harding harding commented on the diff Aug 28, 2015

_translations/en.yml
@@ -750,7 +750,7 @@ en:
address: "Address"
addresstxt: "A Bitcoin address is <b>similar to a physical address or an email</b>. It is the only information you need to provide for someone to pay you with Bitcoin. An important difference, however, is that each address should only be used for a single transaction."
bit: "Bit"
- bittxt: "Bit is a common unit used to designate a sub-unit of a bitcoin - 1,000,000 bits is equal to 1 bitcoin (BTC or B⃦). This unit is usually more convenient for pricing tips, goods and services."
+ bittxt: "Bit is a common unit used to designate a sub-unit of a bitcoin - 1,000,000 bits is equal to 1 bitcoin (BTC or B?). This unit is usually more convenient for pricing tips, goods and services."
@harding

harding Aug 28, 2015

Contributor

NACK this change. This should be in a separate PR, but even if it was, it doesn't render correctly here:

screenshot-github com 2015-08-28 07-08-44

@harding harding added the Wallets label Aug 28, 2015

@Ninkip2p Ninkip2p closed this Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment