Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updates Ninki Wallet description #1035

Merged
merged 1 commit into from Sep 13, 2015

Conversation

Projects
None yet
4 participants
Contributor

Ninkip2p commented Aug 28, 2015

No description provided.

Contributor

harding commented Aug 28, 2015

LGTM. Thanks!

@harding harding added the Wallets label Aug 28, 2015

Contributor

crwatkins commented Aug 28, 2015

OK with me.

Contributor

saivann commented Aug 28, 2015

I'm fine with the change itself. However, is this change worth resetting 13 translations?

Contributor

Ninkip2p commented Aug 28, 2015

@saivann Hi, i take your point and it might seem like a trivial change, however it is something I have been thinking about for some time from analyzing the flow of users we get, their expectations and support requests. This is part of a number of changes including displaying this text on our app pages and on the chrome store page, removing our listing on bitcoin.com (as I feel there isn't enough user education and it raises expectations too high) and also being more explicit on the operational security risks when a user creates an account.

Contributor

saivann commented Aug 31, 2015

FWIW I'm sort of neutral between accommodating translators or @Ninkip2p . I am only worried that other wallet developers will want to update their description more often, and that creates a lot of work.

Contributor

harding commented Aug 31, 2015

My vote is for merging this.

@Ninkip2p and I were talking in IRC about a month ago, and (if I understand correctly) the problem is this: he has an advanced wallet designed for power users, but he suspects that his Bitcoin.org wallet listing is attracting Bitcoin newbies who are getting confused by his wallet.

The intention of this change of text is to discourage those newbies from choosing Ninki. This benefits him directly by maybe reducing the time he spends on support; it also benefits those newbie users by directing them to a more appropriate wallet so they're less likely to end up disappointed or frustrated---which I think is a change worthy of re-translation.

Contributor

Ninkip2p commented Aug 31, 2015

@harding exactly this, yes.

Contributor

saivann commented Aug 31, 2015

@harding @Ninkip2p Great, thanks!

Contributor

crwatkins commented Sep 9, 2015

I'm good with scheduling this merge.

Contributor

harding commented Sep 9, 2015

In the absence of critical feedback, this will be merged on Friday.

@harding harding merged commit 2c3928d into bitcoin-dot-org:master Sep 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Sep 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment