Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Spanish translation completed. #104

Closed
wants to merge 56 commits into
from

Conversation

Projects
None yet
3 participants

With advice from Saïvann and following all translation guidelines the Spanish translation is complete.

Images SVG and PNG are translated too.

Special thanks to William Díaz wdiazux@gmail.com for contributing.

Thank,

Ernesto

ernestova and others added some commits Mar 25, 2013

add page id so that each page is linked to its translated equivalence
fix language id in _layout
fix a few links
remove version history as it is not adapted for translation yet
Merge pull request #3 from leprosys/master
Small changes in the translation of index.html and translation for about page
Contributor

saivann commented Mar 30, 2013

Looks very good so far!

This pull request can be seen live on http://bitcoines.zapto.org/

For many of the following fixes, I recommand to use the little "contentEditable" tips in the README in order to easily preview your work just like a document. https://github.com/bitcoin/bitcoin.org/blob/master/README.md

Here is what I noticed during my review that need to be fixed :

  • Is there a shorter (or longer) way to say "Lo que necesitas saber"? There is a single word on an empty line for the button with a lot of empty space.
  • Sober link is broken in the menu, it seems that it should be acerca-de instead?
  • elige-tu-monedero : Aplicaciones para Monederos description is missing
  • elige-tu-monedero : "Web wallets" is not translated.
  • elige-tu-monedero : Each type of wallet description should have the same height. At best, you should try to adapt the texts. And if you can't get a perfect result, you can use
    to create additionnal empty break lines.
  • elige-tu-monedero : Many wallet description overflow the available space. If necessary, you can remove small parts of the descriptions. They are designed to be very short summary anyway.
  • elige-tu-monedero : Many bitcoin-qt links point to /en/download or /es/download while they should point to /es/descargar
  • bitcoin-para-organizaciones : Pagos rápidos internacionales, the paragraph starts with >.
  • como-funciona : confirmar should link to /es/vocabulario#confirmacion
  • vocabulario : under Mondero, direcciones Bitcoin should link to /es/vocabulario#direccion
  • desarrollo : Wiki de Bitcoin should link to spanish version of https://en.bitcoin.it/wiki/Category:Technical
  • apoya-bitcoin : under Se la red, programa original should point to /es/descargar
  • apoya-bitcoin : mejorar Bitcoin should point to /es/desarrollo
  • apoya-bitcoin : Two "Wiki de Bitcoin" should point to es.bitcoin.it
  • There is also some cases like in "bitcoin-para-entusiastas" where one title on a paragraph ends up with one word on a single line. Sometime it's possible to create a shorter sentence with the same meaning.

OK All are fixed. Hopefully the Choose your wallet will fit.

Contributor

saivann commented Mar 30, 2013

I updated http://bitcoines.zapto.org/, here are remaining things to fix :

  • base-es : acerca-de link is still broken because of a small typo, "url: acerda-de" should be "url: acerca-de"
  • elige-tu-monedero : Programas Monedero have a trailing "&nbps;" that can be replaced with more text or an empty break line (with the html br tag)
  • elige-tu-monedero : Two Bitcoin-Qt links point to /es/download while they should point to /es/descargar ( Bitcoin-Qt that is displayed at the left of Multibit )
  • elige-tu-monedero : Blockchain.info and Bitcoin-Qt still have a too long description. A few others are a bit tight, but that can be ok IMO if you don't get to do something shorter.
  • vocabulario : under Mondero, "direcciones Bitcoin" should link to /es/vocabulario#direccion
  • There is also some cases like in "bitcoin-para-entusiastas", "debes-saber" or "bitcoin-para-personas" where a paragraph ends with one word on a single line. Sometime it's possible to create a shorter or longer sentence with the same meaning. Not mandatory, but often easy to fix and makes a much interesting result.
Contributor

saivann commented Mar 30, 2013

Ah another thing that has been fixed today in other languages :

in descargar.html :

{{ site.DOWNLOAD_VERSION }}-osx.dmg

must be replaced by :

{{ site.DOWNLOAD_VERSION }}-macosx.dmg

Contributor

saivann commented Apr 1, 2013

All of the above are fixed with the last commits except this one :

elige-tu-monedero : Bitcoin-Qt still have a too long description. A few others are a bit tight, but that can be ok IMO if you don't get to do something shorter.

And I sent you a pull request to fix another two dead links I found.

Great job!

Contributor

saivann commented Apr 8, 2013

Please let me know when you think that the translation is ready to be merged. I will adapt it to the recent changes in the layout and push it in one commit.

You can merge it as is.

saivann added a commit that referenced this pull request Apr 10, 2013

saivann added a commit that referenced this pull request Apr 10, 2013

@saivann saivann referenced this pull request Apr 10, 2013

Merged

Add Spanish translation #129

Contributor

saivann commented Apr 11, 2013

@ernestova : In case you have time before the merge gets enough ACK, there is one or two updates in the english version that you can also update in your Spanish version. You can track them here : https://github.com/bitcoin/bitcoin.org/wiki/Translations-tracking

ok DOne.

saivann added a commit that referenced this pull request Apr 11, 2013

Contributor

saivann commented Apr 11, 2013

Thanks, I included your changes in the local spanish branch. The pull request is waiting for ACKs.

@saivann saivann closed this in 18dbb80 Apr 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment