Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Group _includes files in subfolders #1050
Conversation
saivann
changed the title from
Group devdoc _includes files together
to
Group _includes files in subfolders
Sep 5, 2015
|
Read the commit diff and skimmed the HTML diff and this LGTM. I was thinking about doing something like this myself, so thanks! My only request would be to have |
|
@harding Thanks! I have rebased the commit with your suggestion and updated the live preview and HTML diff. I have also added the commands used to generate this PR in the description so it can be quickly rebased after any merge conflict. If that's OK with you, I'd let you choose when is the best moment to merge these changes. |
|
@harding Now that I think of it, wouldn't it be appropriate for references.md to go in the "helpers" directory alongside "vars.md" and "summaries.md"? |
|
@saivann putting it in helpers/ would make sense, please feel free to do that. I slightly prefer to have it in the top level directory I guess mainly because I edit it a lot and am too lazy to suffer through an extra type-two-characters-and-hit-tab for the helpers/ directory. :-) I think merging tomorrow would be good. I think the only pending PR affected by this is #1044 and I have to rebase that to fix a merge conflict anyway. I would like to get this in before either @carnesen or I do any more work on the RPCs. |
|
@harding OK, let's keep references.md where it is now and I'll let you merge this tomorrow, thanks! |
saivann commentedSep 5, 2015
Note; this pull request should be given low priority against any other changes to the devdocs, as it'll conflict with any of them, and is fairly easier to recreate.
We've initially used the _includes path for devdoc content only, but soon added content in subfolders, including the RPC documentation. This pull request aims to reorganize this content a bit to make it more approachable for contributors.
Live preview:
http://bitcointest2.us.to/en/developer-documentation
HTML diff:
http://bitcointest2.us.to/diff.html
(Generated with deterministic plugins only, commits.txt diff was discarded)
ENABLED_PLUGINS="autocrossref glossary redirects alerts releases sitemap" ENABLED_LANGS="fr"Commands to generate this PR from scratch: