Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Update to my new GnuPG key #1120
Conversation
|
ACK |
|
Verified commit sipa/bitcoin.org@7cc0afe contains a new key for Pieter with a signature from the key we have in the repository for Greg. It also has signatures purporting to be from @wtogami and @gwillen, but I haven't previously verified their keys. This is the first time since I've been merging PRs that we've received a key update request that wasn't updating an existing key or which wasn't signed by the previous key. Just to be cautious, I'd like to leave this pull open at least until the weekend just to give other people a chance to comment. If this is unreasonably paranoid, please let me know. |
My only question is whether we want to include the revocation certificate in the repository, and why the old key is revoked rather than expired. |
|
The reason attached to the revocation is "Key is potentially compromised". This revocation should be added to the existing key for now, at least. But it's probably appropriate to wait for more explanation/confirmation/review before adding the new key, I think. The signatures from gmaxwell and wtogami use keys that I'm pretty sure are genuine, and these people AFAIK have direct contact with Pieter. |
|
-----BEGIN PGP SIGNED MESSAGE----- History: somebody broke into a system of mine and may have seen my previous key's passphrase. I have no reason to assume the key itself leaked, but it showed me that my security practices weren't up to par and I didn't want to risk more. iQIcBAEBCgAGBQJWMQWUAAoJENuhpnN5oakxuKcP/3Q3Z2VCZq7oz/uKQrw1jLqV |
|
Updated the PR. It now contains:
|
|
Agreed with letting this open until weekend, since previous key is revoked. I verified that new key is signed by Gregory Maxwell, and the above message by sipa is signed by a subkey of his revoked public key, and his new public key. Given comment from luke-jr above, and assuming sipa would soon publicly sign a message with same key to give us opposite instructions in the event that the new key was generated by an attacker, I think two additional days is a reasonable delay before merging this pull request. |
|
|
No reason to hurry here in any case. We needed to update it in bitcoin core earlier or face the commit checking automation whining on peter's commits. One thing you could do here is immediately add the revocation on the old key, and wait to add the new key. |
harding
added a commit
that referenced
this pull request
Oct 29, 2015
|
Pushed 9340435 with the revocation for the old key as suggested by @gmaxwell (I also added a note in that commit to the README.md so that future maintainers think to do this). See the copy/paste at the end of this comment for details. I think they new key has amassed sufficient evidence for adding to the site, but I'll leave the discussion open until at least noon UTC on Saturday in case anyone has contradictory evidence. I'll fix the merge conflict at merge time. Thank you everyone for helping with this.
|
sipa commentedOct 28, 2015
No description provided.