Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Include Support for Selling Ads #1136

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

Cobra-Bitcoin commented Nov 13, 2015

This pull request introduces code that allows Bitcoin.org to show ads which will be located at the top of the site. The ads aren't shown to mobile visitors.

Note: this pull request itself does not contain any ads. This just sets up the infrastructure necessary for us to sell ads when we need too.

Technical feedback is appreciated. I'd prefer that we avoid getting into debates about how Bitcoin.org should be funded in this pull request. I don't think that belongs here.

@Cobra-Bitcoin Cobra-Bitcoin changed the title from Include ads to Include Support for Selling Ads Nov 13, 2015

Contributor

jonasschnelli commented Nov 13, 2015

Related to: #1087

@luke-jr luke-jr commented on the diff Nov 13, 2015

ad-auth.txt
@@ -0,0 +1,3 @@
+Cøbra (https://bitcointalk.org/index.php?action=profile;u=249495) is authorized
+to sell advertising slots for this website (https://bitcoin.org).
+
@luke-jr

luke-jr Nov 13, 2015

Contributor

This should not be merged until such authorization has consensus. (Yes, this isn't a technical comment, but neither is this part of the change technical nor merely adding infrastructure.)

@jonasschnelli

jonasschnelli Nov 13, 2015

Contributor

Agree with @luke-jr

Contributor

harding commented Nov 13, 2015

I'd prefer that we avoid getting into debates about how Bitcoin.org should be funded in this pull request.

Where can people post to try to change your mind? I stand by my earlier comment that I think this is ultimately the domain owners decision (as is all content on this site), but that I also think seeing advertisements makes new people less willing to contribute. By your not having a debate over the decision and trying to persuade people who doubt this is a good decision, it may also make existing contributors less likely to continue contributing.

On the technical side, I will try to find some time to test this today or on Saturday.

Contributor

theymos commented Nov 13, 2015

I feel like putting it at the top is a bit intrusive. Maybe we should try it in the footer first and see if this generates enough ad income.

There should also be some sort of disclaimer. Currently (unless the ad text will say otherwise), it isn't even clear that it's an ad.

Contributor

Cobra-Bitcoin commented Nov 13, 2015

Thanks for the feedback @theymos. I'll work on changing it to show on the footer, and also add a disclaimer.

@luke-jr luke-jr referenced this pull request Mar 1, 2016

Merged

Add ad infrastructure #1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment