Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add jonasschnelli's PGP key to core commiters list #1138

Merged
merged 1 commit into from Dec 1, 2015

Conversation

Projects
None yet
3 participants
Contributor

jonasschnelli commented Nov 13, 2015

No description provided.

Contributor

harding commented Nov 13, 2015

@jonasschnelli congratulations on being give commit access to bitcoin/bitcoin! You certainly reviewed and tested enough PRs!

Next, condolences on being given commit access, as I'm pretty sure that means lots of people will now expect you to do even more work. :-)

I don't see any signatures on this key or your old key from any of the other core committers, but since this is a new key being added to our site (i.e., it doesn't risk compromising an existing PGP identity we've endorsed), I think it will be satisfactory to merge it once bitcoin/bitcoin#7004 has been merged for a day without reverting. (Anyone who disagrees, please feel free to speak up.)

General question: how do people feel about placing keys for new identities in files/pgp/ (or something)? Although this is a total nitpick, I don't like them cluttering the top-level directory. (Note, I'm not proposing moving existing keys and their updates ever; this is just for totally new URLs.)

Contributor

saivann commented Nov 20, 2015

@jonasschnelli Thanks a lot for your help and work on Bitcoin Core!

@harding I also thought about this (getting the PGP keys into a sub-directory to keep the repository clean and using some server-side magic to serve them either from / and /pgp/). Probably easier to do nothing (e.g. our test units would fail even though the links would be fine on the main server).

Smal detail; Jonas should be displayed before Pieter as, except for the maintainer (Wladimir), the list is ordered by last names.

Other than that, LGTM c8cf91f.

Contributor

harding commented Nov 26, 2015

Jonas's key was merged into Bitcoin Core almost two weeks ago, so I will merge this here tomorrow unless there is any critical feedback.

@harding harding merged commit c8cf91f into bitcoin-dot-org:master Dec 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Dec 1, 2015

Merge PRs #1138 and #1065
- 1138: add jonasschnelli's PGP key to core commiters list
- 1065: Added greenbits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment