Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Wallets: Add Bitcoin Knots #1150
Conversation
harding
added
the
Wallets
label
Dec 2, 2015
|
I suspect that LJR doesn't have many reviews, which is one of our wallet-listing criteria, so I'll mention here that I've used it as my desktop hot wallet in the past (and will probably do so again in the future) and it worked just fine for me. |
|
Concept ACK, though I have never tried LJR. @luke-jr Travis fails. I guess you'd need to add icons. |
ghost
commented
Dec 28, 2015
|
NACK. Bitcoin.org is not for altcoins.
|
|
@celestialwalrus BitcoinLJR is not an altcoin. Concept ACK. |
|
@celestialwalrus What I understood is that BitcoinLJR provides additional features and most of them can be en-/disabled or configured via the params. So this would be useful for "power users", I guess. |
|
Concept ACK. |
ghost
commented
Dec 28, 2015
|
@jonasschnelli XT isn't an altcoin too, but it got removed (Coinbase). |
|
@celestialwalrus BitcoinXT can fork the chain - and therefore - could be seen as altcoin. |
ghost
commented
Dec 28, 2015
|
@jonasschnelli Core can fork (and did) the chain. Why isn't it an altcoin? |
ghost
commented
Dec 28, 2015
|
Anything except this is an altcoin. |
|
@celestialwalrus: right. The question is, which side of the fork is to be considered as altcoin. It's a matter of which perspective you take. Bitcoin.org is a private owned website that represents the opinion of a fork is only reasonable when there is major consens (I guess BitcoinXT/bip101 is controversial). But this is off topic for the PR anyways. |
|
Ok, added a simple icon thing. |
|
Another possible icon if that's too ugly: http://luke.dashjr.org/tmp/code/bitcoinaxe.png |
|
Concept ACK. Disclaimer: Didn't test the wallet part but tested the last two releases of Bitcoin LJR as a full node, had no problems. |
|
(Apparently nobody liked the first icon attempt, so replaced it with the second) |
ghost
commented
Dec 28, 2015
|
@jonasschnelli XT will be the consensus side once activated (75% required)... |
|
@luke-jr out of curiosity, what does the axe symbolize? |
|
It's supposed to be a halberd, symbolising St. Matthew the Apostle who is the patron saint of accountants. Considering renaming to Mattija Bitcoin. |
|
[I removed an earlier comment because it contained an image that looked like a personal attack against one of this conversation's participants. (It may also have been a joke made in poor taste.) Please try to keep the conversation focused on the topic of this PR. Thank you.] |
|
Updated this for Knots. What's holding it back? A few more reviews: |
luke-jr
changed the title from
Wallets: Add Bitcoin LJR
to
Wallets: Add Bitcoin Knots
Jul 1, 2016
|
ACK. I'll merge this soon. This is a great wallet. |
jrmithdobbs
commented
Jul 2, 2016
|
ACK. Luke is a long established member of the community that produces good (if opinionated) work. |
Cobra-Bitcoin
merged commit a10f36c
into
bitcoin-dot-org:master
Jul 5, 2016
1 check passed
|
Why does this use the Bitcoin Core screenshot? It should provide its own I would say. |
fraggle222
commented
Jul 5, 2016
|
How many people are using this wallet? Is there no waiting period where 100-1000 people try it before it gets listed on the site? |
luke-jr commentedDec 1, 2015
Until #1148 is done, might as well just add it as another wallet.
Untested, because Jekyll is impractical to get working.