Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Making clear that segwit is equivalent to a block size increase #1200

Merged
merged 1 commit into from Jan 16, 2016

Conversation

Projects
None yet
9 participants
Contributor

NicolasDorier commented Jan 10, 2016

Segwit is a block size increase, lots of readers of this FAQ care more about the block size than all the goodness of segwit.
So I think this should be clearer.

Contributor

harding commented Jan 10, 2016

I agree mentioning the effective block size increase here would be good, but I suggest that we leave the amount unspecified (since it varies depending upon usage) and link to the answer on that page which goes into more detail. My suggestion:

| April 2016\* |  0.12.x |  Segregated witness deployment including [block size increase](#segwit-size) |

@harding harding added the Core label Jan 10, 2016

Contributor

NicolasDorier commented Jan 10, 2016

I think there is a kind of pavlovian reaction concerning the three words "Block size increase", which is why I think it is more important for them to appear before segwit. (Even if I agree though that segwit is more exciting than the increase in reality)

Contributor

harding commented Jan 10, 2016

Putting "Block size increase" at the beginning of the line makes me feel like we're promising an increase in April, when I conceive of this line as saying that Bitcoin Core will included the necessary segwit code in April and that it will then be up to miners to signal their readiness and activate the actual soft fork.

I know this is splitting hairs, and I apologize, but I don't want to over-promise. I'm hoping that putting "block size increase" in blue (as a link) will be almost as good at drawing reader attention as putting it at the beginning of the line.

What do you think?

jgarzik commented Jan 10, 2016

Block size increase via segregated witness is economically different from increasing core block size.

Please don't conflate the two. That is factually incorrect.

Contributor

harding commented Jan 10, 2016

@jgarzik that's why I suggested adding a link to the detailed answer: https://bitcoin.org/en/bitcoin-core/capacity-increases-faq#segwit-size

Contributor

NicolasDorier commented Jan 10, 2016

Block size increase via segregated witness is economically different from increasing core block size

@jgarzik can you explain ? I agree that for profiting of the increase in segwit, we need segwit adoption in wallets, is that what you mean by "economically different ?". If so I agree.
But if segwit get adopted in wallets, you effectively have the same economical result than a core block size bump: An increase in theorical tx rate equivalent to 1.75MB.

I think it will be adopted by wallet faster than an hardfork can activate though. There is tredemous support behind it. (but this is another topic)

Making clear that segwit is equivalent to a block size increase
Segwit is a block size increase, lots of readers of this FAQ care more about the block size than all the goodness of segwit.
So I think this should be clearer.
Contributor

NicolasDorier commented Jan 10, 2016

@harding I updated the patch to use your proposition. I'm not convinced by it though, but that's better than what there is now.

Contributor

harding commented Jan 10, 2016

@nicolasdorier thanks! ACK a272cb5

@nicolasdorier SW may have the benefit of a blocksize increase, but it is not a blocksize increase proposal nor has it been presented as such. The blocksize increase is a side benefit.

If instead you wish to present it as mainly a blocksize increase proposal via a complicated softfork, that is perfectly fine, but that is not what has been stated so far.

Moreover, with core now having its own website, this content should be moved out of bitcoin.org to bitcoin core's website, thus making any such update pointless.

As such I lean towards a NACK.

Contributor

NicolasDorier commented Jan 10, 2016

@Aquentus the fact that the blocksize increase is a side benefit does not mean it should not be stated. Lots people coming to this FAQ are pissed off because they think nothing is done to improve the block size. Which is wrong, segwit is a block size increase. Not the "Core block size" but a block size increase nevertheless, which increase max tx rate almost as much as a dumb bump.

You understand that segwit do that, but most of redditor does not.

Azulan commented Jan 12, 2016

NACK

While bitcoin.org is no longer a reliable source of bitcoin information, continuing down that path with outright deception would be even worse. Walk up the stairs with your feet, not your hands.

Contributor

NicolasDorier commented Jan 12, 2016

@Azulan can you tell why segwit is not a block size increase ? Or can you propose at least a way to explain that to the user that will suit you ?
Because assuming Segwit is adopted (and it will be very fast) it effectively gives 1.75MB of block space.

Contributor

jl2012 commented Jan 15, 2016

@jgarzik Any segwit user will immediately get a ~50% discount of their fee. The only reason for not switching to segwit is the absolute fee discount is still too low and therefore lack of incentive to upgrade

Contributor

instagibbs commented Jan 15, 2016

ACK. It is an increase, and in fact provides a smooth(er) ramp as the non-segregated portion fills up.

Contributor

petertodd commented Jan 15, 2016

ACK NicolasDorier/bitcoin.org@a272cb5

That's a fair description.

Contributor

harding commented Jan 15, 2016

I'm going to merge this with some other stuff later today, but this and #1202 will be the last content updates of this page I plan to make on Bitcoin.org. Future PRs regarding the FAQ should be sent to https://github.com/bitcoin-core/website

Thanks everyone for your comments

Contributor

luke-jr commented Jan 15, 2016

@jl2012 Fees are miner policy, not something determined by the consensus rules. So it's not appropriate for us to talk about discounting fees at all.

@harding harding merged commit a272cb5 into bitcoin-dot-org:master Jan 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Jan 16, 2016

Merge pulls #1195, #1197, #1200, #1202, and #1208
- 1195: Remove Inside Bitcoins New York and Hong Kong from event page
- 1197: Update _events.yml with correct San Fran event date
- 1200: Making clear that segwit is equivalent to a block size increase
- 1202: Capacity Increases FAQ: more prominently link to roadmap
- 1208: Change references to 'getaddr.bitnodes.io'

Azulan commented Jan 17, 2016

@nicolasdorier Creative accounting is the basis of the legacy financial system. It's not something we should enable and advocate for bitcoin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment