Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Note increased blockchain size #1234
Conversation
|
Would be better to parametrize this, so that it doesn't require an update to all the translations every time. |
|
Yes, unfortunately the parameter can't be used in the translation strings because both are used as (basically) variables. I think the best way to go about this is to break the translations up into two parts and put the chain size between them. E.g.
|
|
We could replace "20GB" with "chain_size_in_gb" in each translation and then use the replace liquid filter.
|
|
Feel free to use my regexes to find all the crazy variations: #1225 |
jonathancross
referenced this pull request
Mar 9, 2016
Merged
Updating Blockchain size from "20GB" to "65GB". #1225
|
Please Note: this PR is missing 5 language files such as |
|
A friend of me just got confused due to this. IMO wey need to merge #1225 or this one soon, and if we can't parametrize it, it would be better to overestimate a bit (say 80GB for instance) than underestimate so that it is a valid maximum for a while... Another thing that confused him is that the download itself is not the limiting factor but the CPU and disk i/o-intensive processing that goes on for all the time in the background. May be nice to mention this. (mentioning pruning would be nice as well, but doesn't change the amount that needs to be download/processed, the main thing that surprises people is how long their pc takes to validate) |
STRML commentedFeb 13, 2016
The blockchain is now over 55GB - gave this number a bump on the download page so users aren't surprised by it.