Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Russian translation complete #124
Conversation
sashafaz
added some commits
Mar 31, 2013
|
Great! I should review your work in the following days. Is there another native Russian speaker that can review your translation and provide feedback? The content of this branch can be found live here : |
Bitc0in
commented
Apr 8, 2013
|
Hello, i am native Russian speaker, i've read translated web pages. Everything looks fine for me. Except for an extra comma at the index page: "Биткоин - это цифровая валюта, протокол, и программное обеспечение, которые включают в себя". I think it should be like "Биткоин - это цифровая валюта, протокол и программное обеспечение, которые включают в себя". |
|
OK, I reviewed your work. Here's what still needs to be fixed. in _config.yml, you can change "Russian" by the equivalence already translated in your language. This will appear in the language menu. Russian people should be able to find their languages easily from all versions of the website. Pages filenames (and urls) need to be translated. See point number 3 and 4 in translation guidelines : Current Ubuntu font produces a mix of bold and not bold characters in titles where there is latin characters. We might need to apply a good russian font (or remote all latin characters from the titles). Do you know a good looking russian font with a open-source licence? Otherwise we can fallback to default sans-serif, but we would need to make sure it doesn't create an inconsistent result in various browsers. choose-your-wallet : The desktop wallet description is longer than the other. It's not mandatory, but trying to get a consistent result between each looks better. The description that overflows in each wallet description won't be a problem once merged with the recent changes in the website. you-need-to-know : The page seems to have a broken html somewhere. The buttons are moving when we go to this page. If you don't find the issue, I will take note to fix it when publishing your work. download : The version history links points to /ru/version-history. It should point to /en/version-history. Also the "Bitcoin for organizations" category is now "Bitcoin for Businesses" since today. So you might want to update this right now instead then in a later pull request since you will rename each file anyway. Otherwise, so far it looks very good to me. Nice job! |
sashafaz
commented
Apr 8, 2013
|
Thanx for the review, saivann. I will try to fix it all this week. |
|
Great! @Bitc0in : Thanks! Feel free to say if you find more typos. Usually, there are always a few hidden ones that take time to find for a reviewer, but that are easily noticed by visitors ;-) |
|
There was also a small change in the text about anonymity recently. You can track those changes here : |
sashafaz
added some commits
Apr 17, 2013
sashafaz
commented
Apr 17, 2013
|
@saivann: Okay, fixed almost everything, I hope. The only things left:
Should I make another pull request or is it alright with this one? (I'm an svn person, a bit new to git). |
|
@alisherfaz : You don't need to open a new pull request, this one is automatically updated. I will take a look at this. Meanwhile, I updated the live demo so you can preview it. I sent you a pull request a few days ago. You can go in your repository, click the "Pull request" tab, and click to merge my pull request. This pull request fixes a build problem with jekyll. |
sashafaz
and others
added some commits
Apr 17, 2013
|
Is there any more Russian reviewer to search for typos and verify accuracy with the english version? @Bitc0in Usually, all other translations had at the very minimum 10 typos / various fixes to do after a review. Did you review all texts in detail? @alisherfaz I just sent you a pull request to fix the Ubuntu font issue. |
sashafaz
commented
Apr 22, 2013
|
@saivann ok, merged. I think there should be some phrases that don't seem native to russians. So I'm now fixing such phrases and searching for more reviewers. |
Bitc0in
commented
Apr 22, 2013
|
@saivann Yup, i've checked all the pages thoroughly. I am in touch with bitcoins since the beginning of 2011, so i understand all the aspects covered in these topics. Yesterday i've checked last version of translation once more and have noticed the following inaccuracy in this sentence: I humble assume that it must be like I've marked what is to be replaced with what using bold font. Next one: I humble assume that it must be like Another one is misstype: Must be I will be reading russian version time to time, because not all inaccuracies can be detected at once. Because i am not a robot. @alisherfaz All in All, nice work. Good luck out there guys! |
saivann
added a commit
that referenced
this pull request
May 18, 2013
|
@alisherfaz @Bitc0in : I converted your work for the upcoming switch to transifex and included Bitc0in fixes. That will make translations much easier to handle, especially for tracking updates and reviews. If you wish to be a coordinator or a translator, you are welcome to join the team : https://www.transifex.com/projects/p/bitcoinorg/ |
sashafaz commentedApr 7, 2013
Saivann Edit : Can be reviewed live at http://bitcoinru.us.to/ru/