Show wallets icon with no link and no name instead of the question mark icon

[saivann]

A few bitcointalk users reported that they didn't think that the current hidden wallets were hidden wallets. To make this more obvious, someone on the Bitcoin Foundation forum suggested to use grey icons of each wallet. This pull request allows this.

Since each wallet names and links remain unavailable before the user click the warning, it seems like a good way to do it. Any more opinions?

Edit : Using the full color icon with no name and no link seems more intuitive.

[jordanful]

I found this really confusing before. But I guess I need clarification — what are hidden wallets?

[saivann]

After discussion, Bitcoin core developers decided that we should not show web wallets without showing a warning to the user first, due to legitimate security concerns for the user.

But on Bitcointalk, some people reported that they believed that those "hidden wallets" were "wallets still to unveil". Or didn't notice them at all, due to the question mark icon. This fix aims to make this easier to understand, by showing the icon like it's disabled instead of the question mark icon.

[jordanful]

I think it's wrong to indicate visually that these are disabled and it's also a weird interaction to have to click 'I understand' to reveal more info about them. For instance, I wouldn't even think to hover over them because I would assume they are 'offline' or 'disabled'.

The ideal fix, IMO, is to just put a warning 'snippet' in each hover bubble, that can be clicked to trigger a modal (or another page) with info as to why these might be potentially harmful.

I think consistent behavior should be the default, and if the warning is clear enough, it should cover that use-case.

[cillianobriain]

Thanks for this pull request saivann. I think it's a definite improvement. Perhaps not ideal as jordanful describes as there is still some potential for confusion but better than the question mark icons. But I don't know what would be the ideal solution at the moment.

[saivann]

@jordanful : Feel free to try something else. I appreciate your quest for improvement. But I predict resistance if you try anything that allows people to see a web wallet without being forced to read a warning first, especially from developers since they have more responsability to protect users.

However, I see no issue about showing the icon in full color as long as the name and the link cannot be seen without clicking on the warning button. But while being a bit more consistent, web wallets would still have their names hidden under the icons. It's pretty hard to obtain a full consistency as the warning is only meant to be applied on web wallets, because users are not in control of their funds with web wallets, nor are they insurred.

Nevertheless, I personally think that this is better than what we have now. If we push this, that shouldn't prevents us to change it again in the future if we come to something better.

[jordanful]

Agreed that yours is an improvement. Ship it!

On Mon, Apr 8, 2013 at 8:07 PM, saivann notifications@github.com wrote:

@jordanful https://github.com/jordanful : Feel free to try something
else. I appreciate your quest for improvement. But I predict resistance if
you try anything that allows people to see a web wallet without being
forced to read a warning first, especially from developers since they have
more responsability to protect users.

However, I see no issue about showing the icon in full color as long as
the name and the link cannot be seen without clicking on the warning
button. But while being a bit more consistent, web wallets would still have
their names hidden under the icons. It's pretty hard to obtain a full
consistency as the warning is only meant to be applied on web wallets,
because users are not in control of their funds with web wallets, nor are
they insurred.

Nevertheless, I personally think that this is better than what we have
now. If we push this, that shouldn't prevents us to change it again in the
future if we come to something better.

—
Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin.org/pull/126#issuecomment-16088644
.

[saivann]

"For instance, I wouldn't even think to hover over them because I would assume they are 'offline' or 'disabled'."

Before I push, do you think it would be better to show the full color icons instead?

[jordanful]

I see no reason not to show the color, since the bubble blocks them anyway
(there's no reason to 'visually block' them before the interaction).

On Mon, Apr 8, 2013 at 8:14 PM, saivann notifications@github.com wrote:

"For instance, I wouldn't even think to hover over them because I would
assume they are 'offline' or 'disabled'."

Before I push, do you think it would be better to show the full color
icons instead?

—
Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin.org/pull/126#issuecomment-16088831
.

[saivann]

We agree then, pushed!