Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Italian translation completed #127

Closed
wants to merge 16 commits into
from

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Apr 10, 2013

Can be reviewed live at : http://bitcoinit.us.to/it/

Contributor

saivann commented Apr 10, 2013

Good work! It can be previewed live here :
http://bitcoinit.us.to/it/

Native italian speakers invited to review : A native Italian speaker would be nice to review and comment your translations.

What I see that needs to be fixed :

Dead links in pages : Most of internal links have not been updated. For instance, I see a lot of links that point to /it/download but this page doesn't exist. The vocabulary page also use only english urls. That can work, but that is better to have this translated. And changing urls is the kind if things we should not change once published online, as much as possible.

Delete version-history : You can delete the file it/version-history

Italian after English in the language bar : "it: Italiano" should be moved after "en: English" in _config.yml.

Last updates : You might also want to include last changes in your translation : https://github.com/bitcoin/bitcoin.org/wiki/Translations-tracking

There are style issues with links in the bubbles and text that overflows. But I will take care to fix thoses issues when the translation will be merged.

@ghost

ghost commented Apr 10, 2013

Native italian speakers invited to review : for now I'm discussing with my relatives, I'll look for other volunteers.

Dead links in pages : fixed

Delete version-history : done

Italian after English in the language bar : done

Last updates : done

Contributor

saivann commented Apr 10, 2013

Great! I will look if I see another native italian speaker in the recent forums threads, in case I can help finding one.

There are a few links that still needs to be fixed.

bitcoin-per-imprese and bitcoin-per-sviluppatori : You should link to https://en.wikipedia.org/wiki/PCI_DSS instead.
scaria : /it/version-history should be /en/version-history
come-funziona : /it/glosssario#blocco should be /it/glossario#blocco There is also two remaining links that point to choose-your-wallet and you-need-to-know at the top.
risorse : One choose-your-wallet link remains

@ghost

ghost commented Apr 11, 2013

Last corrections done. If you can update the live preview I will give that link to others so they can review the translations.
If there will be github users, I'll point them to the italian translation issue for comments.

Contributor

saivann commented Apr 11, 2013

I confirm that all issues I have found so far are now fixed. The live preview has been updated, thanks!

@ghost

ghost commented Apr 28, 2013

Hi
two history university students are going to help me, texts revision on the way.

Contributor

saivann commented Apr 28, 2013

@Joif Very much appreciated, thanks.

Stemby commented Apr 30, 2013

Please, could you use "commissione/commissioni" instead of "tassa/tasse"?

See: https://bitcointalk.org/index.php?topic=50863.msg1982684#msg1982684

Thank you!

@ghost

ghost commented May 2, 2013

Proofreading done.
Thank you Stemby, let me know if there are other suggestions.

saivann added a commit that referenced this pull request May 3, 2013

Contributor

saivann commented May 3, 2013

I have prepared the local branch that is nearly ready to merge.

I notice that "Portafogli per dispositivi mobili" is too long and that three paragraphs have an inconsistant lenght :
http://bitcoinit.us.to/it/scegli-il-tuo-portafoglio

Can you improve this? Otherwise, the rest looks good.

Do you want your username or your full name as an attribution in the git log?

Thanks for your work on this

@ghost

ghost commented May 3, 2013

I notice that "Portafogli per dispositivi mobili" is too long

I noticed it too, unfortunately the exact translation "Portafogli mobili" is misleading, a better short translation could be "Portafogli per smarpthone" but it also doesn't fit in a single row.
The only way is to have just two words like "Portafogli smartphone", it isn't the better translation but I think that a common user can easily understand what the title are referring to.
If it seems good I'd go for "Portafogli smartphone".

and that three paragraphs have an inconsistant lenght

Sorry I didn't get it, can you be more specific?

Do you want your username or your full name as an attribution in the git log?

My username should be good.

I got another proofreading, I'm working on it but I think I'll push it in a day or two.

Contributor

saivann commented May 3, 2013

capture du 2013-05-03 12 35 36

Portafogli smartphone looks fine at least. Here's what I mean in the above image.

I will wait the last proofreading, thanks!

@ghost

ghost commented May 4, 2013

proofreading and texts updated following the latest english pages, "secure your wallet" page added.

Contributor

saivann commented May 4, 2013

I've updated the bitcoin.org branch, do you consider your work ready to be merged?

Please be sure to put extra attention on the "secure your wallet" page as it serves sensitive texts.

If you want to make other updates before we merge, can you replace your branch by the bitcoin.org "it" branch before? That will make things easier. I can give you instructions if you need it.

https://github.com/bitcoin/bitcoin.org/tree/it

@ghost

ghost commented May 6, 2013

Everything but "secure your wallet" is triple-checked, let me re-check this one.
To replace my branch with the "it" one, is it sufficient to fork it?

Contributor

saivann commented May 8, 2013

If you simply fork the branch, just give me a link to the new branch and that will be perfect. Thanks!

@ghost

ghost commented May 9, 2013

please ignore the last commits, I only synchronized my master branch with the bitcoint "it" branch.

@ghost

ghost commented May 9, 2013

I triple-checked the "secure your wallet" page and I can consider the entire work ready.
Now, maybe synchronize my master branch with the "it" one was not the clever thing to do. Please tell me, how can I commit this last update whthout messing up your work? Thank you.

Contributor

saivann commented May 9, 2013

@Joif : No problem, I can import your secure-your-wallet page very easily regardless of how you publish it (it is not a large group of small changes). So you can update your current branch or push a new branch. It's up to you. Thanks for your hard work!

@ghost

ghost commented May 9, 2013

Ok then, my master branch is updated and everything seems ok!

Contributor

saivann commented May 9, 2013

Awesome. I might migrate to transifex bitcoin#178 before including your translation. Unless this pull request needs more work, I don't expect a long delay before your translation is included.

Contributor

saivann commented May 17, 2013

@Joif : I converted your work for the upcoming switch to transifex. If you wish, I can set you as the coordinator (or just a normal member) of the translation team : https://www.transifex.com/projects/p/bitcoinorg/ . Feel free to invite other people to be a part of it. Thanks for your hard work on this.

@ghost

ghost commented May 20, 2013

@saivann : not a poblem for me to be a coordinator, do as you like. I don't know yet how transifex works but I'll study it soon. Thank you!

Contributor

saivann commented May 20, 2013

@Joif : Then feel free to sign in to transifex and ask to be in the Italian team. I should accept your request in the following hours. Basically, transifex is just a user-friendly interface that allows translate sentences in team. And it produces the final structured .yml file containing all translations that we can integrate in the website.

@saivann saivann closed this in ee09b20 May 22, 2013

saivann added a commit that referenced this pull request May 22, 2013

Merge pull request #188 from bitcoin/it
Add Italian (it) translation (thanks Joif) (fixes #127)

jl2012 pushed a commit to jl2012/bitcoin.org that referenced this pull request Apr 5, 2016

Merge pull request #127 from veqtrus/gh-pages
summary for 2016-02-25 meeting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment