Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add Spanish translation #129
Conversation
jordanful
commented
Apr 11, 2013
|
Sweet! |
rdponticelli
commented
Apr 11, 2013
|
Ok, should I make a new commit or can I just amend this one? |
|
@rdponticelli : You can just make a new commits / pull requests until everyone is satisfied. I will clean the branch history anyway before we merge the final pull request. |
|
@ernestova Any comment on the last changes? |
ernestova
commented
Apr 12, 2013
|
They are good to me. From: saivann notifications@github.com @ernestova Any comment on the last changes? |
|
@rdponticelli : Do you consider the translation ready to be merged? |
ernestova
commented
Apr 15, 2013
|
I think is in good standing. From: saivann notifications@github.com @rdponticelli : Do you consider the translation ready to be merged? |
rdponticelli
commented
Apr 15, 2013
|
Let me give it a last look. I think some texts can use some homogenization of treatment... |
dserrano5
commented
Apr 15, 2013
|
Re: treatment, should we go with "tú" or "usted"? |
rdponticelli
commented
Apr 15, 2013
|
I would believe that informal would be better for bitcoin's main target audience. So, "tú" would be ok, IMHO |
ernestova
commented
Apr 15, 2013
|
That depends alot form where you are. Mexicans use "tu", most centralamerica and part of south american use "usted". What matter most if have the translation out for the spanish speaking people, as soon as possible. |
|
I agree. If you all agree that current translation is accurate and understandable, low-priority improvements can be made later. Meanwhile, there are thousands of visitors that would benefit of your great work every day. |
rdponticelli
commented
Apr 15, 2013
|
Yeah, I guess it can be merged and further improvements can be made later. So ACK. |
dserrano5
commented
Apr 15, 2013
|
I think the original english sentence "Most parts of security are handled by the protocol on the client and Bitcoin network side" could use some improvement. |
saivann
added a commit
that referenced
this pull request
Apr 15, 2013
saivann
merged commit 96ab95e
into
master
Apr 15, 2013
saivann
deleted the
spanish branch
Apr 15, 2013
|
Thanks for your hard work on this. Please make a pull request or open an issue if you see anything you feel needs to be improved. You can track required translation updates there in the future : https://github.com/bitcoin/bitcoin.org/wiki/Translations-tracking |
saivann commentedApr 10, 2013
Spanish translation has been reviewed both for technical mistakes by me and for translation accuracy by at least two native speakers. I consider it ready to be merged.
This translation can be seen live here : http://bitcoines.zapto.org/es/
Original pull request : bitcoin#104