Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add Simple Bitcoin Wallet #1302
Conversation
btcontract
added some commits
May 21, 2016
|
I have reviewed Simple Bitcoin Wallet based on the current wallet requirements criteria and my evaluation is below. Last year this wallet was reviewed as Visual Bitcoin Wallet and I recommended another review after more usage was identified. The summary is that the wallet passes on security and overall design, and only one concerning issue was found last year which was immediately fixed. The wallet behaved well, met functional criteria, and was completely stable. I gladly recommend Simple Bitcoin Wallet for listing. I concur with the scoring in the pull request. Simple Bitcoin Walletv1.07Review Version 2016052301The wallet list is based on the personal evaluation of the maintainer(s) and regular contributors of this site, according to the criteria detailed below. These requirements are meant to be updated and strengthened over time. Innovative wallets are exciting and encouraged, so if your wallet has a good reason for not following some of the rules below, please submit it anyway and we'll consider updating the rules. NOTE This wallet was previously named "Visual Bitcoin Wallet" and was previously submitted for listing under that name. This wallet is from the same code base with UI changes. Basic requirements:
NOTE No independent security audit is available PASS Sufficient users and feedback found:
PASS No indication found
PASS No indication found
PASS Uses bitcoinj
PASS No indication found
PASS Reviews found on Google Play from August 2015
NOTE When reviewed last year under the name Visual Bitcoin Wallet, a concerning rounding math error was discovered both while sending and requesting funds PASS This was reported and immediately fixed
PASS Website at http://btcontract.com and http://www.btcontract.com redirects to HTTPS
PASS https://btcontract.com/ has an A+ rating
PASS Executable code is available on Google Play and https://btcontract.com has a max-age of 365 days
PASS The developer, github user btcontract, Anton Kumaigorodski, maintains the source and his email is listed on https://btcontract.com and Google Play page
PASS A new change address is used for each transaction
NOTE Encryption keys are stored on the mobile device protected by a password PASS Passwords must be 6 characters or longer NOTE Poor passwords such as "123456" or "password" are accepted. A password complexity check or meter should be considered.
PASS Backups are made by recording the BIP39 seed phrase available at setup or from wallet settings
PASS Funds can be restored by erasing app data from the Android Settings app and starting over by entering the saved phrase. The BIP39 phrase was also successfully used to restore funds to a MultiBit HD wallet.
PASS https://github.com/btcontract/wallet is kept up to date Optional criteria (some could become requirements):
NOTE No independent security audits are available
PASS Displays an unused address for each receive NOTE A receive address may be re-displayed if it has not yet received a transaction
PASS Does not show "received from" addresses
PASS A transaction generated by the wallet was signed with pybitcointools and the same RFC 6979 signature with low S was generated
PASS Website links to github issue reporting and provides the developer's email address
PASS Supports BIP32 with standard m/0'/c/i BIP32 path
PASS Provides users with an option to view the seed along with an option to read documentation explaining the importance
PASS Scrypt (N=65536) is used for key generation with AES 256 bit encryption for storage |
btcontract commentedMay 21, 2016
Simple Bitcoin Wallet is a refined version of an original app I've proposed to add a few months ago: #1108
After some fair use and user feedback I've decided to remove all the features which proved to be too confusing or irrelevant, hence the name change.
Website: https://btcontract.com/
Play Store: https://play.google.com/store/apps/details?id=com.btcontract.wallet
F-Droid: https://f-droid.org/repository/browse/?fdfilter=simple+bitcoin+wallet&fdid=com.btcontract.wallet
Reddit discussion: https://www.reddit.com/r/Bitcoin/comments/3ws2td/visual_bitcoin_wallet/
Repo: https://github.com/btcontract/wallet