Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add correctly sized icon for Simple Bitcoin Wallet #1312

Merged
merged 5 commits into from Jun 23, 2016

Conversation

Projects
None yet
5 participants
Contributor

btcontract commented Jun 17, 2016

No description provided.

Contributor

crwatkins commented Jun 17, 2016

@btcontract, thanks for such a quick update to your icon; I'm sorry we didn't catch that before merging.

LGTM.

Contributor

schildbach commented Jun 22, 2016

These commits should be squashed into one. There is no need to replace and delete the icon 4 times in 5 commits (one commit being empty).

Contributor

crwatkins commented Jun 22, 2016

True.

Contributor

btcontract commented Jun 22, 2016

Similar PR from @schildbach replaces icon in one commit, should I just close this one?

@Cobra-Bitcoin Cobra-Bitcoin merged commit 4dbe167 into bitcoin-dot-org:master Jun 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

schildbach commented Jun 27, 2016

For some reason, though this PR is merged it didn't become active on the live page.
wget https://bitcoin.org/img/wallet/simplebitcoinwallet.png
fetches the old image.

Contributor

laanwj commented Jun 27, 2016

These commits should be squashed into one. There is no need to replace and delete the icon 4 times in 5 commits (one commit being empty).

Yeah, this looks strange, and apparently didn't work.

Contributor

btcontract commented Jun 27, 2016

Well this is embarrassing. I've used github web interface to upload a correct icon last time because was away from working machine. Here's a new PR which undoes this one and adds an icon avoiding web interface, hope I did it right this time: #1321

Contributor

schildbach commented Jun 27, 2016

I think it's a webserver synching problem. The git repo has the correct icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment