Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add correctly sized icon for Simple Bitcoin Wallet #1312
Conversation
btcontract
added some commits
Jun 17, 2016
|
@btcontract, thanks for such a quick update to your icon; I'm sorry we didn't catch that before merging. LGTM. |
crwatkins
referenced this pull request
Jun 22, 2016
Closed
Resize "Simple Bitcoin" icon to match all the other wallets. #1316
|
These commits should be squashed into one. There is no need to replace and delete the icon 4 times in 5 commits (one commit being empty). |
|
True. |
|
Similar PR from @schildbach replaces icon in one commit, should I just close this one? |
Cobra-Bitcoin
merged commit 4dbe167
into
bitcoin-dot-org:master
Jun 23, 2016
1 check passed
|
For some reason, though this PR is merged it didn't become active on the live page. |
Yeah, this looks strange, and apparently didn't work. |
|
Well this is embarrassing. I've used github web interface to upload a correct icon last time because was away from working machine. Here's a new PR which undoes this one and adds an icon avoiding web interface, hope I did it right this time: #1321 |
|
I think it's a webserver synching problem. The git repo has the correct icon. |
btcontract commentedJun 17, 2016
No description provided.