/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Clarify that Pubkey Scripts are called scriptPubKe #1323

Merged
merged 2 commits into from Jul 5, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Flowdalic @harding @Cobra-Bitcoin
@Flowdalic
Contributor

Flowdalic commented Jun 30, 2016

Readers could get the impression that the script for fulfilling the conditions is called scriptPubKey in code (which is not true).
@Flowdalic
Clarify that Pubkey Scripts are called scriptPubKe 
Readers could get the impression that the script for fulfilling the conditions is called scriptPubKey in code (which is not true).
a37ecd0

Flowdalic added a commit to Flowdalic/bitcoin.org that referenced this pull request Jun 30, 2016

@Flowdalic
Make ScriptSig description a bit more verbose 
and also to keep the style of bitcoin-dot-org#1323
47ca3af

@Flowdalic Flowdalic referenced this pull request Jun 30, 2016

Merged

Make ScriptSig description a bit more verbose #1324

@harding harding commented on an outdated diff Jun 30, 2016

View full outdated diff
_data/glossary/en/pubkey-script.yaml
@@ -10,7 +10,7 @@ required:
A script included in outputs which sets the conditions that must
be fulfilled for those satoshis to be spent. Data for
fulfilling the conditions can be provided in a signature script.
- Called a scriptPubKey in code.
+ Pubkey Scripts are called a `scriptPubKey` in code.
@harding

harding Jun 30, 2016

Contributor

The rephrasing is a good idea, thanks! Could you drop the backtics? Two reasons: (1) they won't be rendered by markdown everywhere this is used, which is why this field is called summary_max_255_characters_no_formatting and (2) scriptPubKey is used in most Bitcoin documentation without being rendered as a code string.
@Flowdalic
Contributor

Flowdalic commented Jul 1, 2016

Removed backticks
@harding
Contributor

harding commented Jul 1, 2016

ACK. Thanks again!

@Cobra-Bitcoin Cobra-Bitcoin merged commit 550d9ba into bitcoin-dot-org:master Jul 5, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment