Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding Android as supported OS for breadwallet #1382

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
4 participants
Contributor

jmacwhyte commented Sep 29, 2016

The Android version of breadwallet came out a couple months ago.

Contributor

jmacwhyte commented Oct 21, 2016

Is this repo still maintained? Who is in charge of merging PR's? There seems to be a pretty big backlog.

Contributor

achow101 commented Oct 21, 2016

The repo and website are still maintained, just a little slow to update. @Cobra-Bitcoin does most of the merging and such with input from some other people. It's all listed on the about page.

Contributor

Cobra-Bitcoin commented Oct 22, 2016

With stuff concerning wallets, I usually wait until @crwatkins leaves a comment to decide whether to merge or not (he's the wallets maintainer).

There's also not much space available for Android wallets, we're already listing way too many, that's why I'm holding off on merging this until I know what @crwatkins thinks about it.

Contributor

crwatkins commented Oct 22, 2016

I had reviewed screen shots, the source code, and the submitted scoring criteria, but I was having trouble finding a device to test on. My current device is running Android 5. Another device I tried wouldn't let me set a PIN (and thus breadwallet wouldn't run). A more recent device had some strange PIN interaction with the device (which I have reported to support). It hasn't been for a lack of trying.
I just tried a device that breadwallet seems to be happy with and had the same excellent experience as breadwallet on iOS (except for an occasion message from Android concerned that breadwallet was not responding and wondering if I wanted to wait, which I did).

I'm happy to recommend adding Android to the breadwallet listing. I concur with the current scoring in the PR.

Contributor

jmacwhyte commented Oct 22, 2016

Thank you for the thorough review!

Contributor

jmacwhyte commented Nov 2, 2016

@Cobra-Bitcoin What do you think? Could we merge? It would fill out the second row of Android wallets ;)

@Cobra-Bitcoin Cobra-Bitcoin merged commit 68e7496 into bitcoin-dot-org:master Nov 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment