Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Alert system retirement notice #1392
Conversation
achow101
and others
added some commits
Oct 13, 2016
|
This post should go up today before the actual alert as a pre-warning warning. IRC Discussion of this post: https://botbot.me/freenode/bitcoin-core-dev/2016-10-13/?msg=74784693&page=6 |
|
This LGTM (note: I don't have merge access; either @Cobra-Bitcoin or @laanwj will have to merge). Here's what the alert will look like on the Alerts page:
I confirmed the alert is listed in the RSS feed. Here's a full page preview of the rendered Alert:
|
|
I also confirmed that the redirection from |
|
LGTM. I'm not sure we're actually sending it the 15th. If we're RCing a new release ASAP, it would be a little unfortunate to cause the few remaining users on older versions to upgrade to something that is immediately outdated. Page should go up in advance (though perhaps not highlighted on the site). @laanwj ? |
|
As background information for whatever decision is made: This PR as of commit 1b8bcce is emphasized on the site only through a warning icon in the footer on every page:
Clicking that link will take the reader to the Alerts page where this alert is prominently featured (see screenshot above). The alert is also listed in the alerts RSS feed. There is no colored banner at the top of ever page as we've done in the past for serious situations. (The part of the YAML header that would cause that to be rendered has the text written but is commented out; I assumed this was so it can be uncommented when the pre-final alert is actually sent.) If this page's YAML header field |
|
I'll adjust the dates as we go. Should this have the banner displayed? I wasn't sure what to do about that. I think that the banner should be displayed initially for the first few days of the Alert then taken down until the Final alert is made and it can go back up briefly for that too.
Considering that we are still probably a month out from the release itself, I think it would be fine to do this in the next couple of days. |
|
The banner color can be toggled; we have the following presets but others can be created: ## (Optional; default=alert) CSS class to set banner color
## alert = red | warning = orange | success = green | info = blue
bannerclass: infoI think an More info about Bitcoin.org alerts options is here: https://github.com/bitcoin-dot-org/bitcoin.org#alerts |
|
I've set the banner to |
|
For reference, here's a preview of the banner as set in 8039c66 :
(This is from the main page; the banner is shown on every Bitcoin.org page.) |
|
Looks good. Not sure if I should merge this now, it doesn't look like things have been 100% decided yet. |
|
@Cobra-Bitcoin It really depends on when the 0.13.1 RC cycle begins (and when @gmaxwell wants to send the alert). IMO we can merge this now and move forward with the alert for tomorrow. I can update the dates. |
There are still two bugs, so rc1 will come earliest next week. But this does not help here in any case because we don't want people to upgrade production systems to a rc. |
|
utACK 8039c66 (Of course the dates need adjustment, first) |
|
Pushed the dates back by one day and also added some additional links to related PRs. |
|
ACK, thanks for writing this |
|
Bumped the dates. I think this can be merged |
|
ACK 0ea7206 |
achow101 commentedOct 13, 2016
•
edited
As per discussion on the -core-dev IRC, here is the post for the retirement of the alert system. The actual alert will happen tomorrow. This post should go up today before the actual alert as a pre-warning warning.
IRC Discussion of this post: https://botbot.me/freenode/bitcoin-core-dev/2016-10-13/?msg=74784693&page=6