/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Take remainder from the curve's prime instead of G #1406

Merged
merged 1 commit into from Jan 9, 2017

Conversation

Reviewers
No reviews
Assignees

@wbnns wbnns

Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
3 participants
@fivepiece @wbnns @harding
@fivepiece
Contributor

fivepiece commented Nov 11, 2016

Instances of point( ( key + i ) % G ) should read point( (key + i) % p )
@fivepiece
Take remainder from the curve's prime instead of G 
Instances of `point( ( key + i ) % G )` should read `point( (key + i) % p )`
f741ed7
@wbnns
Contributor

wbnns commented Dec 3, 2016

@fivepiece Hello, thanks for submitting this PR. I just wanted to leave this note to let you know we're checking into this and will follow back up here, soon.
@fivepiece
Contributor

fivepiece commented Dec 3, 2016 • edited

@wbnns wbnns self-assigned this Dec 9, 2016

@wbnns wbnns added the Under Review label Dec 17, 2016

@harding
Contributor

harding commented Jan 3, 2017

ACK. Thanks!

@wbnns wbnns added Merge Scheduled and removed Under Review labels Jan 5, 2017

@wbnns
Contributor

wbnns commented Jan 5, 2017

Unless others object, this will be merged on Sunday, January 8th.

@harding Thanks!

@wbnns wbnns merged commit 69d3ee8 into bitcoin-dot-org:master Jan 9, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment