Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
RPC Developer reference updated based on 0.12.1 #1410
Conversation
|
Wow, this is awesome! Thanks, @Mirobit! I haven't generated a local preview, but I took a quick skim at the diff and it looks good. I'll try to make some time today or tomorrow to preview each of the changes. |
|
Thanks for doing this! |
harding
suggested changes
Nov 16, 2016
Reviewed a local preview, left a couple comments, and opened a PR to @Mirobit's repository with some suggested edits.
Thanks again for this work!
| +- n: "→<br>`size`" | ||
| + t: "number (int)" | ||
| + p: "Required<br>(exactly 1)" | ||
| + d: "The size of this block in serialized block format, counted in bytes" |
harding
Nov 16, 2016
Contributor
On 0.13.1, I don't have a size field in the result. Is this something that's on 0.12.0, or is an extra left in from copying from the getblock fields?
| @@ -188,7 +203,9 @@ Result: | ||
| "walletconflicts" : [ | ||
| ], | ||
| "time" : 1418695703, | ||
| - "timereceived" : 1418925580 | ||
| + "timereceived" : 1418925580, |
harding
Nov 16, 2016
Contributor
This example doesn't include the new trusted field documented above.
Mirobit
Nov 16, 2016
Contributor
The trusted field is only shown when the transaction is still unconfirmed. I didn't have an unconfirmed tx in my wallet.
harding
and others
added some commits
Nov 16, 2016
|
Do you want me to squash all commits? |
|
@Mirobit Only if you want to squash them. We've never been strict squashers on Bitcoin.org. Unless someone discovers an issue, I suspect that this will be merge the next time @Cobra-Bitcoin processes the PR queue. |
Mirobit commentedNov 15, 2016
I updated all changes to the RPC API from 0.11.0 to 0.12.1.
An update based on 0.13.1 will follow soon.