Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Changed version data type to signed int32 #1414

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
4 participants
Contributor

axvm commented Nov 20, 2016

Fixed typo version data type in block headers. Based on issue #1413

Contributor

luke-jr commented Nov 23, 2016

NACK, it's a bitfield, not an integer. Implementation details are irrelevant...

Contributor

jonasschnelli commented Nov 23, 2016

@luke-jr: It's a bitfield when deploying SF with BIP9, but "old" blocks are still using a unsigned integer as block version. I agree that the documentation should mention the new bitfield after BIP9. But the internal type can and should be a int32 instead of a uint32.

Contributor

luke-jr commented Nov 23, 2016

The top bit is unusable even pre-BIP 9, so meh. :)

@Cobra-Bitcoin Cobra-Bitcoin merged commit c8d68aa into bitcoin-dot-org:master Dec 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment