Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updating info on high-priority-transactions #1421

Merged
merged 1 commit into from Dec 18, 2016

Conversation

Projects
None yet
4 participants
Contributor

jonathancross commented Dec 3, 2016

A few unrelated lines also had trailing whitespace which was also removed.

_includes/devdoc/guide_transactions.md
-time. The remaining space in each block is typically allocated to transactions
-based on their fee per byte, with higher-paying transactions being added
-in sequence until all of the available space is filled.
+Older versions of Bitcoin Core recognized so-called "[high-priority transactions][/en/glossary/high-priority-transaction]{:#term-high-priority-transactions}{:.term}" which spent satoshis which had not moved for a long time. These transaction were often exempt from the normal fee requirements. Before Bitcoin Core 0.12, 50 KB of each block would be reserved for these high-priority transactions, however this is now set to 0 KB by default. As of Bitcoin Core 0.14, the entire concept of "high priority" / free transactions will be removed, meaning that all transactions will simply be prioritized based on their fee per byte, with higher-paying transactions being added in sequence until all of the available space is filled.
@MarcoFalke

MarcoFalke Dec 4, 2016

Contributor

version .14 will have relay disabled by default. (You can still enable most of the priority logic in 0.14)

Removal is targeted for 0.15.

@luke-jr

luke-jr Dec 4, 2016

Contributor

Removal from mining is NACK'd.

@jonathancross

jonathancross Dec 11, 2016

Contributor

Thanks for the feedback, I've reworded and uploaded a new version.

Contributor

MarcoFalke commented Dec 4, 2016

ACK

@wbnns wbnns self-assigned this Dec 9, 2016

_includes/devdoc/guide_transactions.md
-time. The remaining space in each block is typically allocated to transactions
-based on their fee per byte, with higher-paying transactions being added
-in sequence until all of the available space is filled.
+Older versions of Bitcoin Core recognized so-called "[high-priority transactions][/en/glossary/high-priority-transaction]{:#term-high-priority-transactions}{:.term}" which spent satoshis which had not moved for a long time. These transaction were often exempt from the normal fee requirements. Before Bitcoin Core 0.12, 50 KB of each block would be reserved for these high-priority transactions, however this is now set to 0 KB by default, meaning that all transactions will simply be prioritized based on their fee per byte, with higher-paying transactions being added in sequence until all of the available space is filled. As of Bitcoin Core 0.14, high-priority-transaction relaying will also be disabled by default and the related code is targeted to be removed in v0.15.
@jonathancross

jonathancross Dec 11, 2016

Contributor

I reworded this based on feedback from @MarcoFalke and @luke-jr, hopefully this is more accurate.

@jonathancross

jonathancross Dec 12, 2016

Contributor

Hmmm... seems I've unknowingly stepped into contentious territory with this change and misunderstood @luke-jr's concerns. Will work on making the wording more neutral and update here again when ready for another look.

@jonathancross jonathancross changed the title from Updating info on deprecated high-priority-transactions to Updating info on high-priority-transactions Dec 13, 2016

-time. The remaining space in each block is typically allocated to transactions
-based on their fee per byte, with higher-paying transactions being added
-in sequence until all of the available space is filled.
+In the past, these "priority" transaction were often exempt from the normal fee requirements. Before Bitcoin Core 0.12, 50 KB of each block would be reserved for these high-priority transactions, however this is now set to 0 KB by default. After the priority area, all transactions are prioritized based on their fee per byte, with higher-paying transactions being added in sequence until all of the available space is filled. <!-- Consider adding links to blockmaxsize and blockmaxweight options once available in the glossary. -->
@jonathancross

jonathancross Dec 13, 2016

Contributor

Hi @luke-jr, hopefully this version addresses your concerns as mentioned in email? If not, please provide feedback. Thanks.

@luke-jr

luke-jr Dec 13, 2016

Contributor

lgtm

_includes/devdoc/guide_transactions.md
-As of Bitcoin Core 0.9, transactions which do not count as high-priority transactions
-need to pay a [minimum fee][/en/glossary/minimum-relay-fee]{:#term-minimum-fee}{:.term} (currently 1,000 satoshis) to be
+Bitcoin Core 0.9, added a [minimum fee][/en/glossary/minimum-relay-fee]{:#term-minimum-fee}{:.term} (currently 1,000 satoshis) to be
@luke-jr

luke-jr Dec 13, 2016

Contributor

Pretty sure the minimum fee was always there, but 0.9 just changed the logic around trickling below-min-fee somewhat. It's only being explicitly disabled (by default) in 0.14. Perhaps these details are irrelevant, though, since in practice a minimum fee is needed to broadcast.

@jonathancross

jonathancross Dec 14, 2016

Contributor

Okay, will remove the "added" part.

-As of Bitcoin Core 0.9, transactions which do not count as high-priority transactions
-need to pay a [minimum fee][/en/glossary/minimum-relay-fee]{:#term-minimum-fee}{:.term} (currently 1,000 satoshis) to be
-broadcast across the network. Any transaction paying only the minimum fee
+As of Bitcoin Core 0.9, a [minimum fee][/en/glossary/minimum-relay-fee]{:#term-minimum-fee}{:.term} (currently 1,000 satoshis) has been required to
@jonathancross

jonathancross Dec 14, 2016

Contributor

Removed the "added" part.

Contributor

wbnns commented Dec 16, 2016

Unless others object, this will be merged on Sunday, December 18th.

@jonathancross @MarcoFalke @luke-jr Thanks!

@wbnns wbnns merged commit 7be5012 into bitcoin-dot-org:master Dec 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jonathancross jonathancross deleted the jonathancross:high-priority-transactions branch Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment