/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

choose-your-wallet: Adding info about wallet properties. #1422

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Reviewers
No reviews
Assignees

@wbnns wbnns

Labels
Merge Scheduled Wallets
Projects
None yet
Milestone
No milestone
3 participants
@jonathancross @crwatkins @wbnns
@jonathancross
Contributor

jonathancross commented Dec 3, 2016

I did not find a clear page defining what the various properties like "checkfailtransparencynew" mean. Is there something better we can link to?
@jonathancross
choose-your-wallet: Adding info about wallet properties.
This commit was signed with a verified signature.
@jonathancross jonathancross Jonathan Cross
GPG key ID: D8578DF8EA7CCF1B Learn about signing commits
276532f
@crwatkins
Contributor

crwatkins commented Dec 3, 2016

@jonathancross I believe you have indeed found the definitive self-describing definition at https://github.com/bitcoin-dot-org/bitcoin.org/blob/master/_translations/en.yml

@crwatkins crwatkins added the Wallets label Dec 9, 2016

@wbnns wbnns self-assigned this Dec 9, 2016

@crwatkins
Contributor

crwatkins commented Dec 9, 2016

@jonathancross I know this is really picky, but should the file reference in the comment be relative to our source tree instead of an absolute github URL?

I'm good with the addition either way.
@jonathancross
Contributor

jonathancross commented Dec 11, 2016

@crwatkins I think a full url is easier to copy / paste into a new tab for reference.
But happy to change if you'd prefer relative path.
@crwatkins
Contributor

crwatkins commented Dec 11, 2016

LGTM
@wbnns
Contributor

wbnns commented Dec 12, 2016

Unless others object, this will be merged on Wednesday, December 14th.

@wbnns wbnns added the Merge Scheduled label Dec 12, 2016

@wbnns wbnns merged commit fdbec65 into bitcoin-dot-org:master Dec 16, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jonathancross jonathancross deleted the jonathancross:wallet-properties branch Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment