Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update example_transactions.md #1430

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

whitemagpie commented Dec 9, 2016

changed a few outputs mainly coz the error messages and details in outputs have changed with new version of Bitcoin Core.

@wbnns wbnns self-assigned this Dec 9, 2016

A few suggestions but ACK

+ "sequence": 4294967295,
+ "error": "Input not found or already spent"
+ }
+ ]
}
@Mirobit

Mirobit Dec 15, 2016

Contributor

There are some whitespaces missing (772-779).

-error: {"code":-22,"message":"TX rejected"}
+error code: -25
+error message:
+Missing inputs
{% endhighlight %}
@Mirobit

Mirobit Dec 15, 2016

Contributor

Is this the original formatting of the error message? Mine is structured like this

258: txn-mempool-conflict (code -26)

- 95c37e148f78c77255",
- "iscompressed" : true,
- "account" : ""
+ "isvalid": true,
@Mirobit

Mirobit Dec 15, 2016

Contributor

One space to much.

@wbnns wbnns added the Under Review label Dec 17, 2016

Contributor

wbnns commented Feb 9, 2017

@whitemagpie Hello, thanks for submitting this. Could you please incorporate @Mirobit 's suggestions and also rebase this PR to resolve the conflicts?

@Mirobit Thanks for the review!

@wbnns wbnns added the Dev Docs label Mar 1, 2017

Contributor

wbnns commented Mar 13, 2017

@whitemagpie Hello, since it's been a while, I'm going to go ahead and close this for now. If you have time in the future to incorporate the changes that @Mirobit mentioned, it would be great if you could submit a new pull request!

@wbnns wbnns closed this Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment