/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Developer Doc: REST API 0.11, 0.12, 0.13 update #1450

Merged
merged 3 commits into from Feb 13, 2017

Conversation

Reviewers

@harding harding

Assignees

@wbnns wbnns

Labels
Dev Docs Merge Scheduled
Projects
None yet
Milestone
No milestone
3 participants
@Mirobit @wbnns @harding
@Mirobit
Contributor

Mirobit commented Dec 20, 2016 • edited

The REST API developer documentation as of 0.13 (no changes in 0.13.1).

I did not fully understand the GetUtxos call:

  • How are Outpoints defined? What is ?
  • What is the point of the return field bitmap?

@wbnns wbnns self-assigned this Dec 21, 2016

@harding

harding approved these changes Jan 3, 2017
View changes

I sent @mirobit a small PR with some minor suggested changes, but this looked excellent to me. Thanks!

Previewed ACK when above PR is merged.

_includes/devdoc/bitcoin-core/rest/intro.md
-configuration file.
+configuration file. Make sure that the RPC interface is also activated.
+Set `server=1` in `bitcoin.conf` or supply the `-server` argument when
+starting the program.
@harding

harding Jan 3, 2017

Contributor

Maybe this should also mention that starting the program by the name bitcoind implies -server.

@Mirobit

Mirobit Jan 5, 2017

Contributor

Thanks, you are right. Addressed this in the latest commit.

@wbnns wbnns added the Dev Docs label Jan 3, 2017

@wbnns
Contributor

wbnns commented Jan 5, 2017

@harding Thanks for the review! @Mirobit Thank you as well for putting this together. I'll put this on hold and schedule it to be merged once Harding's PR is incorporated.

@wbnns wbnns added the On Hold label Jan 5, 2017

@Mirobit
Contributor

Mirobit commented Jan 5, 2017 • edited

@harding Thanks for the review and for expanding the GetUtxos call. I am glad that someone is doing this.

In case anyone is wondering, the updated/new in 0.12/0.13 labels are not displayed since they are only introduced in #1429.

@wbnns This is ready to merge.

@Mirobit Mirobit referenced this pull request Jan 7, 2017

Merged

Add REST calls, new OP codes and BIPs to dev search #1479

@wbnns wbnns added Merge Scheduled On Hold and removed On Hold Merge Scheduled labels Feb 9, 2017

@wbnns
Contributor

wbnns commented Feb 9, 2017

@Mirobit Thanks. Could you please resolve the conflicts? Once you do I'll move to #1479. 👍

@wbnns wbnns added the Changes Requested label Feb 9, 2017

Mirobit and others added some commits Dec 14, 2016

@Mirobit
REST 0.11, 0.12, 0.13 update 
references.md, developer-reference.md, _autocrossref.yaml and
_config.yml not yet updated
8a93b97
@harding @Mirobit
Dev Docs: minor edits to 0.13.x REST API update
3ded57c
@Mirobit
server bitcoind fix
c10415a
@Mirobit
Contributor

Mirobit commented Feb 9, 2017

@wbnns Thanks, rebased.

@wbnns wbnns added Merge Scheduled and removed Changes Requested On Hold labels Feb 9, 2017

@wbnns
Contributor

wbnns commented Feb 9, 2017

@Mirobit Thanks!

Unless others object, this will be merged on Sunday, February 12th.

@wbnns wbnns merged commit 04e6dfd into bitcoin-dot-org:master Feb 13, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Mirobit Mirobit deleted the Mirobit:restupdate branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment