Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Adding ArcBit wallet #1459
Conversation
wbnns
self-assigned this
Dec 26, 2016
crwatkins
added
the
Wallets
label
Dec 26, 2016
crwatkins
self-assigned this
Dec 26, 2016
|
Thanks for the PR @stequald! You may want to remove the entry for the web wallet since that's for website-only wallets and I believe that you have a Chrome extension. You may have used GreenAddress as an example which links their Chrome app as their web link. I think that should link to https://greenaddress.it instead. I'll ping @greenaddress to fix that in the GreenAddress listing if appropriate. |
crwatkins
added
the
Changes Requested
label
Dec 27, 2016
|
@crwatkins Just updated PR with removal of web wallet. |
|
Hey @stequald thanks for the quick update! You'll also want to remove
|
|
@crwatkins Oops, missed that. Just updated. |
|
Thanks @stequald |
crwatkins
removed
the
Changes Requested
label
Dec 28, 2016
wbnns
added
the
Under Review
label
Jan 31, 2017
|
Hi @stequald, Under the android: and ios: sections, you have os listed as both android and ios (for both of them). I think you probably meant to list ios for ios and android for android. |
|
Hey @crwatkins I've just updated PR with the fix. |
|
I have reviewed the ArcBit wallet based on the current wallet requirements criteria and my evaluation is below. The summary is that I can recommend this wallet for listing. I concur with the current scoring in the pull request. ArcBitiOS Version 1.4.2Chrome app version 1.1.7Android version 1.0.5Review Version 2017020801The wallet list is based on the personal evaluation of the maintainer(s) and regular contributors of this site, according to the criteria detailed below. These requirements are meant to be updated and strengthened over time. Innovative wallets are exciting and encouraged, so if your wallet has a good reason for not following some of the rules below, please submit it anyway and we'll consider updating the rules. NOTE The "Brain Wallet" mode of the Chrome app was considered a set of accessory tools and not the default mode of the wallet. It was tested (and worked well), but it was not reviewed against the listing criteria. Basic requirements:
PASS ArcBit for iOS has been available for 19 months and various conversation can be found on reddit.com and bitcointalk.org without concerning issues.
PASS No indication. Problems found have been resolved.
PASS No indication. Support has been very responsive.
PASS No indication found: Chrome app uses bitcoinjs and cryptojs; iOS app uses CoreBitcoin; Android app uses bitcoinj
PASS No indication
PASS Released 30 June 2015 - https://www.reddit.com/r/Bitcoin/comments/3bn3n7/announcement_launching_arcbit_first_bitcoin/
PASS No concerning bug was found. Minor issues reported were addressed quickly. NOTE During a wallet restore, some UI elements may be slow at updating to the new wallet; this is being investigated.
PASS http://arcbit.io redirects to https://arcbit.io
PASS https://arcbit.io has rating A+
PASS max-age is 2 years with preload
PASS https://arcbit.io
PASS A list of new receive addresses is displayed
PASS A new change address is used in each transaction
N/A
N/A
PASS Backup of BIP39 phrase is in settings. Wallet reminds users to backup the phrase. NOTE Full wallet metadata can be backed up to local disk from the Chrome browser, or to iCloud from iOS.
PASS Wallets were restored from just the BIP39 phrase as well as with full metadata from the saved backup NOTE Funds were restored to wallets from other developers, such as Multibit HD, using the BIP39 phrase
PASS https://github.com/arcbit
N/A
N/A
Optional criteria (some could become requirements):
NOTE No known security audits
PASS iOS app and Android app does not display "received from" addresses FAIL Chrome app displays "received from" address; ArcBit has plans to address this
PASS A transaction signed by the Android ArcBit wallet was duplicated and signed with custom code using pybitcointools which is RFC 6979 based. The signatures match. The other ArcBit wallets also use libraries which produce deterministic signatures.
PASS Provides a support email address on https://arcbit.io
PASS https://arcbit.io has preload headers enabled and is pending submission
N/A
PASS Supports standard BIP44 with multiple accounts
PASS New wallets popup a pointer to wallet backup in Settings
PASS Uses 10k rounds of PBKDF2
FAIL Does not encrypt (Chrome browser local storage) by default NOTE There is an option to encrypt in Settings
N/A
|
|
@stequald @crwatkins Thank you both very much for the work on this. Unless others object, this will be merged on Wednesday, February 15th. |
stequald commentedDec 25, 2016
Hi, I would like to add the bitcoin wallet ArcBit to Bitcoin.org.